From: Felipe Balbi <balbi@ti.com>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: Felipe Balbi <balbi@ti.com>, Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
patrice.chotard@st.com, srinivas.kandagatla@gmail.com,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, peppe.cavallaro@st.com
Subject: Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC
Date: Wed, 20 Aug 2014 13:24:06 -0500 [thread overview]
Message-ID: <20140820182405.GD6023@saruman.home> (raw)
In-Reply-To: <20140723143323.GA26565@griffinp-ThinkPad-X1-Carbon-2nd>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Wed, Jul 23, 2014 at 03:33:23PM +0100, Peter Griffin wrote:
> > > > > + reset_control_assert(dwc3_data->rstc_pwrdn);
> > > > > +
> > > > > + pinctrl_pm_select_sleep_state(dev);
> >
> > pinctrl will select sleep and default states automatically for you.
>
> I've left this in v3, as greping around I couldn't see how that could
> happen automatically.
>
> Also I just double checked with linusw on irc who confirmed that the
> only state which is ever auto-selected is "default". All other states,
> as well as going back to default state need to be explicitly called.
>
> Hope thats ok.
yeah, that's fine. Thanks :-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-20 18:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 6:25 [PATCH v2 0/3] Add ST dwc3 glue layer driver Peter Griffin
2014-07-05 6:25 ` [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC Peter Griffin
[not found] ` <1404541530-27856-2-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-07 12:46 ` Lee Jones
2014-07-22 9:18 ` Peter Griffin
2014-07-22 10:15 ` Lee Jones
2014-07-22 14:57 ` Felipe Balbi
2014-07-22 15:45 ` Lee Jones
2014-07-22 15:51 ` Felipe Balbi
[not found] ` <20140722155117.GF20588-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-07-22 15:56 ` Lee Jones
2014-07-23 14:33 ` Peter Griffin
2014-08-20 18:24 ` Felipe Balbi [this message]
2014-07-07 13:21 ` Jingoo Han
2014-07-22 9:38 ` Peter Griffin
2014-07-05 6:25 ` [PATCH v2 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation Peter Griffin
2014-07-07 11:00 ` Lee Jones
2014-07-05 6:25 ` [PATCH v2 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture Peter Griffin
[not found] ` <1404541530-27856-4-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-07 10:51 ` Lee Jones
2014-07-08 7:40 ` Maxime Coquelin
[not found] ` <53BBA075.9040204-qxv4g6HH51o@public.gmane.org>
2014-07-08 7:53 ` Lee Jones
2014-07-08 9:01 ` Maxime Coquelin
2014-07-10 13:27 ` Felipe Balbi
2014-07-10 13:39 ` Lee Jones
2014-07-10 15:24 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820182405.GD6023@saruman.home \
--to=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=peppe.cavallaro@st.com \
--cc=peter.griffin@linaro.org \
--cc=srinivas.kandagatla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).