From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v3 6/6] ARM: dts: qcom: Add APQ8074 Dragonboard PMIC GPIO bindings Date: Wed, 20 Aug 2014 16:06:13 -0700 Message-ID: <20140820230612.GE16274@sonymobile.com> References: <1407771634-14946-1-git-send-email-iivanov@mm-sol.com> <1407771634-14946-7-git-send-email-iivanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1407771634-14946-7-git-send-email-iivanov@mm-sol.com> Sender: linux-arm-msm-owner@vger.kernel.org To: "Ivan T. Ivanov" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "linux-arm-msm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Mon 11 Aug 08:40 PDT 2014, Ivan T. Ivanov wrote: > diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi b/arch/arm/boot/dts/qcom-apq8074-dragonboard-pmics-pins.dtsi [...] > + > +&pm8941_gpios { > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pm8941_gpios_default>; > + > + pm8941_gpios_default: default { > + group-1 { > + pins = "gpio1", "gpio2", "gpio5", "gpio29"; > + function = PMIC_GPIO_FUNC_NORMAL; This looks really strange, I can't get myself to stop thinking that you forgot the <> around this (I know it's a string). I don't like these defines. > + input-enable; > + power-source = ; > + qcom,pull-up-strength = ; > + }; > + group-6 { /* TUSB3_HUB-RESET */ Why not name the nodes something useful? If you name it tusb3-hub-reset you can skip the comment. > + pins = "gpio6"; > + function = PMIC_GPIO_FUNC_NORMAL; > + output-high; > + drive-push-pull; > + power-source = ; > + qcom,pull-up-strength = ; > + qcom,drive-strength = ; > + }; Regards, Bjorn