From: Guenter Roeck <linux@roeck-us.net>
To: Harini Katakam <harinik@xilinx.com>
Cc: wim@iguana.be, grant.likely@linaro.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, michals@xilinx.com,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
harinikatakamlinux@gmail.com, svemula@xilinx.com,
anirudh@xilinx.com
Subject: Re: [PATCH v4 1/2] watchdog: Add Cadence WDT driver
Date: Fri, 22 Aug 2014 00:33:44 -0700 [thread overview]
Message-ID: <20140822073344.GA23635@roeck-us.net> (raw)
In-Reply-To: <20140821185722.GA17481@roeck-us.net>
On Thu, Aug 21, 2014 at 11:57:22AM -0700, Guenter Roeck wrote:
> On Thu, Jul 31, 2014 at 12:10:54PM +0530, Harini Katakam wrote:
> > Add Cadence WDT driver. This is used by Xilinx Zynq.
> >
> > Signed-off-by: Harini Katakam <harinik@xilinx.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Hah, that was too fast. The driver causes build errors for a number or
architectures, including x86_64.
drivers/watchdog/cadence_wdt.c: In function 'cdns_wdt_writereg':
drivers/watchdog/cadence_wdt.c:93:2: error: implicit declaration of function
'writel_relaxed' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/watchdog/cadence_wdt.o] Error 1
make[1]: *** [drivers/watchdog] Error 2
Please make sure that the driver is only configurable for architectures
supporting writel_relaxed.
Thanks,,
Guenter
next prev parent reply other threads:[~2014-08-22 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 6:40 [PATCH v4 1/2] watchdog: Add Cadence WDT driver Harini Katakam
2014-07-31 6:40 ` [PATCH v4 2/2] devicetree: Add Cadence WDT devicetree bindings documentation Harini Katakam
2014-08-21 19:00 ` Guenter Roeck
2014-08-21 18:57 ` [PATCH v4 1/2] watchdog: Add Cadence WDT driver Guenter Roeck
2014-08-22 7:33 ` Guenter Roeck [this message]
2014-08-22 7:54 ` Harini Katakam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822073344.GA23635@roeck-us.net \
--to=linux@roeck-us.net \
--cc=anirudh@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=harinik@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=svemula@xilinx.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).