From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Cc: "Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Tero Kristo" <t-kristo-l0cyMroinI0@public.gmane.org>,
"Paul Walmsley" <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>,
"Kevin Hilman"
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>,
"Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Santosh Shilimkar"
<santosh.shilimkar-l0cyMroinI0@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Dave Gerlach" <d-gerlach-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 3/3] pinctrl: single: AM437x: Add pinctrl compatibility
Date: Mon, 25 Aug 2014 10:26:32 -0700 [thread overview]
Message-ID: <20140825172632.GO17254@atomide.com> (raw)
In-Reply-To: <1408716062-26055-4-git-send-email-nm-l0cyMroinI0@public.gmane.org>
* Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> [140822 07:03]:
> From: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
>
> AM437x pinctrl definitions now differ from traditional 16 bit OMAP pin
> ctrl definitions, in that all 32 bits are used to describe a single pin
>
> Also the location of wakeupenable and event bits have changed.
>
> Signed-off-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
> [nm-l0cyMroinI0@public.gmane.org: minor updates]
> Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> ---
> .../bindings/pinctrl/ti,omap-pinctrl.txt | 1 +
> drivers/pinctrl/pinctrl-single.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
> index d45386d..af225fe 100644
> --- a/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
> @@ -6,5 +6,6 @@ Required properties:
> "ti,omap4-padconf" - OMAP4 compatible pinctrl
> "ti,omap5-padconf" - OMAP5 compatible pinctrl
> "ti,dra7-padconf" - DRA7 compatible pinctrl
> + "ti,am437-padconf" - AM437x compatible pinctrl
>
> See Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt for further details.
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index 598d600..784de13 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -1987,6 +1987,12 @@ static const struct pcs_soc_data pinctrl_single_dra7 = {
> .irq_status_mask = (1 << 25), /* WAKEUPEVENT */
> };
>
> +static const struct pcs_soc_data pinctrl_single_am437x = {
> + .flags = PCS_QUIRK_SHARED_IRQ,
> + .irq_enable_mask = (1 << 29), /* OMAP_WAKEUP_EN */
> + .irq_status_mask = (1 << 30), /* OMAP_WAKEUP_EVENT */
> +};
> +
> static const struct pcs_soc_data pinctrl_single = {
> };
>
> @@ -1999,6 +2005,7 @@ static struct of_device_id pcs_of_match[] = {
> { .compatible = "ti,omap4-padconf", .data = &pinctrl_single_omap_wkup },
> { .compatible = "ti,omap5-padconf", .data = &pinctrl_single_omap_wkup },
> { .compatible = "ti,dra7-padconf", .data = &pinctrl_single_dra7 },
> + { .compatible = "ti,am437-padconf", .data = &pinctrl_single_am437x },
> { .compatible = "pinctrl-single", .data = &pinctrl_single },
> { .compatible = "pinconf-single", .data = &pinconf_single },
> { },
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-08-25 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 14:00 [PATCH 0/3] pinctrl: Add DRA7/AM437x pinctrl compatibility Nishanth Menon
[not found] ` <1408716062-26055-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-08-22 14:01 ` [PATCH 1/3] pinctrl: bindings: Add OMAP pinctrl binding Nishanth Menon
[not found] ` <1408716062-26055-2-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-08-25 17:25 ` Tony Lindgren
2014-08-25 19:03 ` Nishanth Menon
2014-08-29 7:27 ` Linus Walleij
2014-08-22 14:01 ` [PATCH 2/3] pinctrl: single: Add DRA7 pinctrl compatibility Nishanth Menon
[not found] ` <1408716062-26055-3-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-08-25 17:26 ` Tony Lindgren
2014-08-29 7:29 ` Linus Walleij
2014-08-22 14:01 ` [PATCH 3/3] pinctrl: single: AM437x: Add " Nishanth Menon
[not found] ` <1408716062-26055-4-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-08-25 17:26 ` Tony Lindgren [this message]
2014-08-29 7:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825172632.GO17254@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=d-gerlach-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=j-keerthy-l0cyMroinI0@public.gmane.org \
--cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=santosh.shilimkar-l0cyMroinI0@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).