From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 2/5] MFD: RK808: Add new mfd driver for RK808 Date: Tue, 26 Aug 2014 09:32:06 +0100 Message-ID: <20140826083206.GD9574@lee--X1> References: <1408973516-21395-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: Chris Zhong , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , Liam Girdwood , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Alessandro Zummo , Mike Turquette , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Grant Likely , Lin Huang , Tao Huang , Eddie Cai , zhangqing , xxx , Heiko =?iso-8859-1?Q?St=FCbner?= , Olof Johansson , Sonny Rao List-Id: devicetree@vger.kernel.org On Mon, 25 Aug 2014, Doug Anderson wrote: > On Mon, Aug 25, 2014 at 6:31 AM, Chris Zhong wro= te: > > The RK808 chip is a power management IC for multimedia and handheld > > devices. It contains the following components: > > > > - Regulators > > - RTC > > > > The RK808 core driver is registered as a platform driver and provid= es > > communication through I2C with the host device for the different > > components. > > > > Signed-off-by: Chris Zhong >=20 > You need a Signed-off-by: Zhang Qing >=20 > > --- [...] > > +static struct rk808 *g_rk808; >=20 > I think Lee's "Grim" comment here was that prefixing globals with "g_= " > is not consistent with the Linux coding style. Just remove the "g_". That and the seemingly unavoidable use of a global pointer. [...] > > +static const struct i2c_device_id rk808_ids[] =3D { > > + { "rk808", 0 }, >=20 > I think Lee wanted the above to be: >=20 > { "rk808", }, Right, but the ',' is now superfluous. [...] > I didn't do a thorough review, just compared to Lee's old feedback. > Maybe a good idea to get in the habit to responding to others comment= s > with "Done" so others know you have addressed each comment? Please only do this locally or in your head. Reading replies to reviews containing only a break-down of what has been fixed is a waste of everyone's time. If/when replying to comments/observations that you do _not_ agree with, please snip out all of the ones that you _do_ agree with. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html