From: Thierry Reding <thierry.reding@gmail.com>
To: Ajay kumar <ajaynumb@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ajay Kumar <ajaykumar.rs@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"kgene.kim@gmail.com" <kgene.kim@gmail.com>,
"inki.dae@samsung.com" <inki.dae@samsung.com>,
"seanpaul@google.com" <seanpaul@google.com>,
"jg1.han@samsung.com" <jg1.han@samsung.com>,
"joshi@samsung.com" <joshi@samsung.com>,
"prashanth.g@samsung.com" <prashanth.g@samsung.com>
Subject: Re: [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow
Date: Thu, 28 Aug 2014 15:10:18 +0200 [thread overview]
Message-ID: <20140828131017.GD14388@ulmo> (raw)
In-Reply-To: <CAEC9eQN+EJmrG70O+2Sg5GD0OHudhqo5beGDN8K4_kmOKKPOmw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1996 bytes --]
On Thu, Aug 28, 2014 at 03:04:32PM +0530, Ajay kumar wrote:
> On Thu, Aug 28, 2014 at 2:45 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Thu, Aug 28, 2014 at 06:34:33AM +0100, Ajay kumar wrote:
> >> On Wed, Aug 27, 2014 at 8:31 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> >> > On Wed, Aug 27, 2014 at 03:48:27PM +0100, Ajay Kumar wrote:
> >> >> Add DT nodes for ptn3460 bridge chip and panel.
> >> >> Add backlight enable pin and backlight power supply for pwm-backlight.
> >> >> Also add bridge phandle needed by dp to enable display on snow.
> >> >>
> >> >> Note that, snow doesn't support "chunghwa,claa101wb01" panel,
> >> >> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> >> >> has similar LCD timings.
> >> >
> >> > What does it actually have?
> >> >
> >> > It's fine to have "chunghwa,claa101wb01" as a fallback but we should
> >> > have an identifier for the actual display, too.
> >> Actual display used is "AUO,B116XTN0", for which no data currently exists
> >> in panel file. Instead of adding a new panel_desc for B116XTN0,
> >> why not we reuse existing ones? what is the "identifier" you are talking about?
> >
> > The compatible string.
> >
> > So in the dts we'd have compatible = "au0,b116xtn0", "chunghwa,claa101wb01";
> Sorry, hardware engineer says actual LCD name is "auo,b116xw03".
>
> > That way if we need specific data we can add it later.
> I think we can add a new panel_desc for "auo,b116xw03".
> Because its actual LCD dimension is 256x144, but "chungwa, claa101wb01" has
> LCD dimension 223x125.
> What is Thierry's opinion on adding this new LCD?
I think you should simply add a new panel_desc for the panel. It may use
similar timings, but it's likely not "compatible" in the way required by
device tree. As you say, dimensions are different and those may have an
influence on the DPI setting. There's really no reason why this should
share the panel_desc with another panel.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-28 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 14:48 [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Ajay Kumar
2014-08-27 14:48 ` [PATCH 2/2] ARM: dts: Add DT changes for display on peach_pit Ajay Kumar
2014-08-27 15:01 ` [PATCH V2 1/2] ARM: dts: Add DT changes for display on snow Mark Rutland
2014-08-28 5:34 ` Ajay kumar
2014-08-28 9:15 ` Mark Rutland
2014-08-28 9:34 ` Ajay kumar
2014-08-28 9:52 ` Mark Rutland
2014-08-28 13:10 ` Thierry Reding [this message]
2014-08-28 14:28 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828131017.GD14388@ulmo \
--to=thierry.reding@gmail.com \
--cc=ajaykumar.rs@samsung.com \
--cc=ajaynumb@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=prashanth.g@samsung.com \
--cc=seanpaul@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).