From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal Date: Thu, 28 Aug 2014 10:37:35 -0400 Message-ID: <20140828143733.GA18084@developer> References: <1409187562-12370-1-git-send-email-caesar.wang@rock-chips.com> <1409187562-12370-2-git-send-email-caesar.wang@rock-chips.com> <2852853.mfRZfFVSev@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2852853.mfRZfFVSev@wuerfel> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Caesar Wang , heiko@sntech.de, rui.zhang@intel.com, grant.likely@linaro.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, huangtao@rock-chips.com, cf@rock-chips.com, dianders@chromium.org, dtor@chromium.org, zyw@rock-chips.com, addy.ke@rock-chips.com, dmitry.torokhov@gmail.com, zhaoyifeng , linux-iio@vger.kernel.org, Jonathan Cameron List-Id: devicetree@vger.kernel.org Ceasar and Arnd, On Thu, Aug 28, 2014 at 10:48:23AM +0200, Arnd Bergmann wrote: > On Thursday 28 August 2014 08:59:19 Caesar Wang wrote: > > Thermal is TS-ADC Controller module supports user-defined mode and automatic mode. > > > > User-defined mode refers,TSADC all the control signals entirely by software > > writing to register for direct control. > > > > Automaic mode refers to the module automatically poll TSADC output,and the results > > Were checked. > > > > If you find that the temperature High in a period of time, an interrupt is generated > > to the processor down-measures taken;if the temperature over a period of time High, > > the resulting TSHUT gave CRU module,let it reset the entire chip, or via GPIO give PMIC. > > > > Signed-off-by: zhaoyifeng > > Signed-off-by: Caesar Wang > > Hi Caesar, > > After looking at the driver (last time I only received the patch for > the binding), I have a more general comment: > > This looks like a general-purpose ADC device, not an IP block that is > specific to thermal management. The binding looks ok for that purpose > but should probably be moved into Documentation/devicetree/bindings/iio/adc/ > as a minor change. > I agree with Arnd's point here. It makes sense to me to have this driver under the IIO umbrella. > On the driver side, I believe the correct way to deal with this setup > is to split your driver into a generic drivers/iio/adc/rockchips-tsadc.c > file, and a smaller thermal driver that uses the iio in-kernel interfaces, > ideally one that is independent of the underlying hardware and can > work on any ADC implementation. > Agreed. If you can write such interface and make your driver to work in such way, that would be great. > I've put the IIO maintainer on Cc in this mail, maybe Jonathan or someone > else on the linux-iio mailing list has some extra insight. > > Arnd Cheers, Eduardo