From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc Date: Thu, 28 Aug 2014 16:11:21 +0100 Message-ID: <20140828151121.GM14650@leverpostej> References: <1409190017-12656-1-git-send-email-kever.yang@rock-chips.com> <20140828091758.GB14650@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140828091758.GB14650@leverpostej> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kever Yang Cc: "heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org" , "dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org" , "sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org" , "addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org" , "cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org" , "xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org" , "wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org" , "lyz-TNX95d0MmH7DzftRWevZcw@public.gmane.org" , "hj-TNX95d0MmH7DzftRWevZcw@public.gmane.org" , "huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Aug 28, 2014 at 10:17:58AM +0100, Mark Rutland wrote: > Hi Kever, > > On Thu, Aug 28, 2014 at 02:40:17AM +0100, Kever Yang wrote: > > We need use the hrtimer, which need the arch-timer to be 'always-on' > > I asked a question on the last posting [1]. Can you please confirm > either way? > > Thanks, > Mark. > > [1] lists.infradead.org/pipermail/linux-arm-kernel/2014-August/282327.html To clarify: if there are low power states that the CPU can enter where we lose state, then this patch isn't correct. A more general approach would be to enable the broadcast hrtimer for arm, as has been done for arm64. See commit 5d1638acb9f6 (tick: Introduce hrtimer based broadcast) which introduced the broadcast hrtimer, and commit 9358d755bd5c (arm64: kernel: initialize broadcast hrtimer based clock event device) which added the requisite plumbing for arm64. Mark. > > > Signed-off-by: Kever Yang > > --- > > > > arch/arm/boot/dts/rk3288.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > > index 5950b0a..698e6ea 100644 > > --- a/arch/arm/boot/dts/rk3288.dtsi > > +++ b/arch/arm/boot/dts/rk3288.dtsi > > @@ -76,6 +76,7 @@ > > , > > ; > > clock-frequency = <24000000>; > > + always-on; > > }; > > > > i2c1: i2c@ff140000 { > > -- > > 1.9.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html