From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node Date: Thu, 28 Aug 2014 18:12:28 +0100 Message-ID: <20140828171228.GR14650@leverpostej> References: <1409204060-9223-1-git-send-email-zhangfei.gao@linaro.org> <1409204060-9223-7-git-send-email-zhangfei.gao@linaro.org> <53FEF4A7.2040001@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <53FEF4A7.2040001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dinh Nguyen Cc: Zhangfei Gao , "haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org" , Jiancheng Xue , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , pawel.moll-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Aug 28, 2014 at 10:21:43AM +0100, Dinh Nguyen wrote: > > > On 8/28/14, 12:34 AM, Zhangfei Gao wrote: > > Signed-off-by: Jiancheng Xue > > Signed-off-by: Zhangfei Gao > > --- > > arch/arm/boot/dts/hisi-x5hd2.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi > > index 152f3ad..7b1cb53 100644 > > --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi > > +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi > > @@ -365,6 +365,15 @@ > > #interrupt-cells = <2>; > > status = "disabled"; > > }; > > + > > + wdg0: wdg@a2c000 { > > A nit-pick here, but everybody else is using 'wdt' for a watchdog timer > node. > > > + compatible = "arm,sp805", "arm,primecell"; > > I didn't see an entry for "arm,sp805" in Documentations, should there be > one? There probably should, yes. It looks like only the sp804 is documented. Pawel, it looks like you were the first sp805,sp810 dt user. Care to put together a couple of documents? ;) Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html