From mboxrd@z Thu Jan 1 00:00:00 1970 From: Courtney Cavin Subject: Re: [PATCH v2] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Date: Fri, 29 Aug 2014 17:47:31 -0700 Message-ID: <20140830004731.GC25668@sonymobile.com> References: <1409354063-20289-1-git-send-email-bjorn.andersson@sonymobile.com> <20140829234128.GB25668@sonymobile.com> <5401174F.8040508@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <5401174F.8040508@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org To: Stephen Boyd Cc: "Andersson, Bj?rn" , Ohad Ben-Cohen , Kumar Gala , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , Suman Anna , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Jeffrey Hugo , Eric Holmberg List-Id: devicetree@vger.kernel.org On Sat, Aug 30, 2014 at 02:14:07AM +0200, Stephen Boyd wrote: > On 08/29/14 16:41, Courtney Cavin wrote: > > On Sat, Aug 30, 2014 at 01:14:23AM +0200, Bjorn Andersson wrote: > >> From: Kumar Gala > >> > >> Add driver for Qualcomm MSM Hardware Mutex block that exists on > >> newer Qualcomm SoCs. > >> > >> Cc: Jeffrey Hugo > >> Cc: Eric Holmberg > >> Cc: Courtney Cavin > >> Signed-off-by: Kumar Gala > >> [bjorn: added pm_runtime calls, from Courtney, > >> added sfpb-mutex compatible, > >> updated DT binding documentation formatting] > >> Signed-off-by: Bjorn Andersson > >> --- > > [...] > >> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig > >> index 3612cb5..2cd39e2 100644 > >> --- a/drivers/hwspinlock/Kconfig > >> +++ b/drivers/hwspinlock/Kconfig > >> @@ -8,6 +8,17 @@ config HWSPINLOCK > >> > >> menu "Hardware Spinlock drivers" > >> > >> +config HWSPINLOCK_MSM > >> + tristate "MSM Hardware Spinlock device" > >> + depends on ARCH_QCOM > > This should also depend on OF, as it won't compile or work without it. > > Doesn't ARCH_QCOM imply OF? ARCH_MULTIPLATFORM has a select USE_OF. Hrm. Apparently. -Courtney