devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Inha Song <ideal.song@samsung.com>,
	broonie@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, sameo@linux.intel.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
	cw00.choi@samsung.com
Subject: Re: [alsa-devel] [PATCH v5 2/2] mfd: arizona: Update DT binding to support INn_MODE init_data
Date: Mon, 1 Sep 2014 10:04:21 +0100	[thread overview]
Message-ID: <20140901090421.GB12043@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140901083400.GD7374@lee--X1>

On Mon, Sep 01, 2014 at 09:34:00AM +0100, Lee Jones wrote:
> On Sat, 30 Aug 2014, Inha Song wrote:
> 
> > This patch update DT binding to support INn_MODE init_data. Each
> > input signal path can be configurated either as a Analogue or
> > Digital using the INn_MODE registers.
> > 
> > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> Applied, thanks.
> 
> > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> > index 5c7e723..7bd1273 100644
> > --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> > @@ -42,6 +42,13 @@ Optional properties:
> >      the chip default will be used.  If present exactly five values must
> >      be specified.
> >  
> > +  - wlf,inmode : A list of INn_MODE register values, where n is the number
> > +    of input signals. Valid values are 0 (Differential), 1 (Single-ended) and
> > +    2 (Digital Microphone). If absent, INn_MODE registers set to 0 by default.
> 
> Please #define these in include/dt-bindings in a subsequent patch.
> 
> And an example?

I have a patch here that I am hoping to push out soon that moves
a lot of defines into include/dt-bindings I can probably roll it
into that or at the least we should probably wait till I have
pushed that out first.

Thanks,
Charles

      reply	other threads:[~2014-09-01  9:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30  2:27 [alsa-devel] [PATCH v5 0/2] mfd: arizona: add support for INn_MODE register control Inha Song
     [not found] ` <1409365639-5320-1-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-08-30  2:27   ` [alsa-devel] [PATCH v5 1/2] mfd: arizona: Add support for INn_Mode " Inha Song
     [not found]     ` <1409365639-5320-2-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-01  8:32       ` Lee Jones
2014-09-01  9:03         ` Charles Keepax
2014-08-30  2:27 ` [alsa-devel] [PATCH v5 2/2] mfd: arizona: Update DT binding to support INn_MODE init_data Inha Song
2014-09-01  8:34   ` Lee Jones
2014-09-01  9:04     ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140901090421.GB12043@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ideal.song@samsung.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).