devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
	tiwai@suse.de, kuninori.morimoto.gx@renesas.com, moinejf@free.fr,
	andrew@lunn.ch, jsarha@ti.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
	alsa-devel@alsa-project.org, shawn.guo@freescale.com,
	linux-kernel@vger.kernel.org,
	Nicolin Chen <nicoleotsuka@gmail.com>
Subject: Re: [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.
Date: Mon, 1 Sep 2014 15:34:12 +0200	[thread overview]
Message-ID: <20140901133412.GA11312@lunn.ch> (raw)
In-Reply-To: <1409545781-20530-2-git-send-email-Li.Xiubo@freescale.com>

On Mon, Sep 01, 2014 at 12:29:35PM +0800, Xiubo Li wrote:
> This patch merge single DAI link and muti-DAI links code together,
> and simply the simple-card driver code.

Hi Xiubo

It would be good to note that this breaks the Binary API with DT
blobs. Old blobs will not work with this new C code.

> And also do some other improvement:

It would be good to put these improvements into separate patches,
making them easier to review.

> +====
> +DAI link node(s) and its or their subnodes:
>  
> -Required dai-link subnodes:
> +There must be one DAI link node exsit at least, and each DAI link must

typ0. It would also be better to say:

There must be at least one DAI link, and each DAI link must

> +contain one CPU subnode and one CODEC subnode.

  Andrew

  parent reply	other threads:[~2014-09-01 13:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01  4:29 [PATCHv1 0/7] simple-card: simplify the code Xiubo Li
2014-09-01  4:29 ` [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code Xiubo Li
     [not found]   ` <1409545781-20530-2-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-09-01  7:42     ` [alsa-devel] " Kuninori Morimoto
2014-09-01  7:48       ` Li.Xiubo
2014-09-01  7:50         ` Kuninori Morimoto
2014-09-02  9:15       ` [alsa-devel] " Li.Xiubo
2014-09-01 15:05     ` Jason Cooper
2014-09-01 13:34   ` Andrew Lunn [this message]
2014-09-01 15:13     ` Mark Brown
     [not found]       ` <20140901151356.GB29327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-02  3:22         ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
2014-09-01  4:29 ` [PATCHv1 2/7] ASoC: simple-card: Adjust the comments of simple card Xiubo Li
2014-09-01  4:29 ` [PATCHv1 3/7] ASoC: dts: vf610-twr: To support simple card newest style Xiubo Li
2014-09-01  4:29 ` [PATCHv1 4/7] ASoC: dts: kirkwood-t5325: " Xiubo Li
2014-09-01 13:41   ` Andrew Lunn
     [not found]     ` <20140901134148.GB11312-g2DYL2Zd6BY@public.gmane.org>
2014-09-02  9:08       ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
2014-09-01  4:29 ` [PATCHv1 5/7] ASoC: dts: r8a7740-armadillo800eva-reference: " Xiubo Li
2014-09-01  4:29 ` [PATCHv1 6/7] ASoC: dts: sh73a0-kzm9g-reference: " Xiubo Li
2014-09-01  4:29 ` [PATCHv1 7/7] ASoC: dts: kirkwood-openrd-client: " Xiubo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140901133412.GA11312@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jsarha@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=moinejf@free.fr \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=shawn.guo@freescale.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).