From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 2/5] MFD: RK808: Add new mfd driver for RK808 Date: Tue, 2 Sep 2014 08:24:37 +0100 Message-ID: <20140902072437.GA17117@lee--X1> References: <1409562468-16586-1-git-send-email-zyw@rock-chips.com> <1409564384-18380-1-git-send-email-zyw@rock-chips.com> <20140901100922.GL7374@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: Chris Zhong , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , Liam Girdwood , Alessandro Zummo , Mike Turquette , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Grant Likely , Lin Huang , Tao Huang , Eddie Cai , zhangqing , xxx , Heiko =?iso-8859-1?Q?St=FCbner?= , Olof Johansson , Sonny Rao , Dmitry Torokhov List-Id: devicetree@vger.kernel.org On Mon, 01 Sep 2014, Doug Anderson wrote: > On Mon, Sep 1, 2014 at 3:09 AM, Lee Jones wrot= e: > > On Mon, 01 Sep 2014, Chris Zhong wrote: > > > >> The RK808 chip is a power management IC for multimedia and handhel= d > >> devices. It contains the following components: > >> > >> - Regulators > >> - RTC > >> - Clkout > >> > >> The RK808 core driver is registered as a platform driver and provi= des > >> communication through I2C with the host device for the different > >> components. > >> > >> Signed-off-by: Chris Zhong > >> Signed-off-by: Zhang Qing > > > > Couple of nits. Once fixed you can apply my: > > > > Acked-by: Lee Jones > > > > [...] > > > >> +/* > >> + * MFD core driver for Rockchip RK808 > >> + * > >> + * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd > > > > Author? >=20 > I asked Chris to remove the author in my response to an earlier > version since it's at the bottom (MODULE_AUTHOR) and it seems extra > duplication. You are the boss though, so if it should go both places > then Chris should add this back. Sorry for the bad advice, Chris. Yes, both places please. They do different things. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html