From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Pawel Moll <pawel.moll@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH 5/8] ARM: l2x0: move DT parsing for cache props
Date: Tue, 2 Sep 2014 13:43:26 +0100 [thread overview]
Message-ID: <20140902124326.GP30401@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1409659354-23553-6-git-send-email-linus.walleij@linaro.org>
On Tue, Sep 02, 2014 at 02:02:31PM +0200, Linus Walleij wrote:
> The current diagnostic prints in the l2x0 driver will print
> warnings like this if the AUX register i modified by the
> mask and set words passed to the l2x0_init() function:
>
> L2C: platform modifies aux control register: 0x02020fff -> 0x02730fff
> L2C: DT/platform modifies aux control register: 0x02020fff -> 0x02730fff
Notice that there are two here.
The first means that the platform passed values which resulted in an
actual modification to the control register. This happens in
l2x0_of_init() to identify values of aux_mask/aux_val which result
in manipulation of the control register by hard-coded platform values.
The second means that the platform _or_ the DT resulted in an actual
modification of the control register. This happens in __l2c_init(),
after the DT has been parsed, or after the non-DT code paths to identify
any remaining modifications.
I don't see any point to this patch.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-09-02 12:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 12:02 [PATCH 0/8] ARM RealView DeviceTree support v5 Linus Walleij
2014-09-02 12:02 ` [PATCH 1/8 v2] leds: add a driver for syscon-based LEDs Linus Walleij
2014-09-02 12:02 ` [PATCH 2/8 v2] leds: add device tree bindings for register bit LEDs Linus Walleij
2014-09-02 12:24 ` Arnd Bergmann
2014-09-08 11:25 ` Linus Walleij
2014-09-02 14:22 ` Geert Uytterhoeven
2014-09-08 11:14 ` Linus Walleij
2014-09-02 12:02 ` [PATCH 3/8 v2] power: reset: driver for the Versatile syscon reboot Linus Walleij
2014-09-02 12:32 ` Arnd Bergmann
2014-09-02 12:02 ` [PATCH 4/8] soc: add driver for the ARM RealView Linus Walleij
2014-09-02 12:02 ` [PATCH 5/8] ARM: l2x0: move DT parsing for cache props Linus Walleij
2014-09-02 12:43 ` Russell King - ARM Linux [this message]
2014-09-05 11:10 ` Linus Walleij
2014-09-02 12:02 ` [PATCH 6/8] ARM: l2c: parse 'cache-size' and 'cache-sets' properties Linus Walleij
2014-09-02 12:02 ` [PATCH 7/8] ARM: l2x0: support associativity from DT Linus Walleij
2014-09-02 13:17 ` Russell King - ARM Linux
2014-09-02 12:02 ` [PATCH 8/8 v5] ARM: realview: basic device tree implementation Linus Walleij
2014-09-02 12:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902124326.GP30401@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).