From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4-panda: Fix model and SoC family details
Date: Wed, 3 Sep 2014 14:27:33 -0700 [thread overview]
Message-ID: <20140903212732.GI11766@atomide.com> (raw)
In-Reply-To: <1409258703-21188-1-git-send-email-nm@ti.com>
* Nishanth Menon <nm@ti.com> [140828 13:45]:
> Currently we claim that omap4-panda and omap4-panda-es are essentially
> the same, but they are not since PandaBoard-ES uses OMAP4460 and
> PandaBoard uses OMAP4430.
>
> So, split the common definition and make the model name available.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Based on v3.17-rc2
>
> Testing logs: (boot test):
> Before Patch(v3.17-rc2)
> 1: pandaboard-es: Boot PASS: http://slexy.org/raw/s209HfpVTs
> 2: pandaboard-vanilla: Boot PASS: http://slexy.org/raw/s21YNmOhQL
>
> After Patch
> 1: pandaboard-es: Boot PASS: http://slexy.org/raw/s20FH76BTn
> 2: pandaboard-vanilla: Boot PASS: http://slexy.org/raw/s2vFLcfkBu
Thanks applying into omap-for-v3.18/fixes-not-urgent.
> Note: 'ti,omap4-panda-es' is not documented in bindings, not entirely
> sure if we should be doing the same for every board compatibility.
That should probably be done on regular basis with some script
if we want to keep the documentation updated.
Regards,
Tony
> arch/arm/boot/dts/omap4-panda-common.dtsi | 3 ---
> arch/arm/boot/dts/omap4-panda-es.dts | 5 +++++
> arch/arm/boot/dts/omap4-panda.dts | 5 +++++
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
> index 8cfa3c8..1505135 100644
> --- a/arch/arm/boot/dts/omap4-panda-common.dtsi
> +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
> @@ -8,9 +8,6 @@
> #include "elpida_ecb240abacn.dtsi"
>
> / {
> - model = "TI OMAP4 PandaBoard";
> - compatible = "ti,omap4-panda", "ti,omap4430", "ti,omap4";
> -
> memory {
> device_type = "memory";
> reg = <0x80000000 0x40000000>; /* 1 GB */
> diff --git a/arch/arm/boot/dts/omap4-panda-es.dts b/arch/arm/boot/dts/omap4-panda-es.dts
> index 816d1c9..2f1dabc 100644
> --- a/arch/arm/boot/dts/omap4-panda-es.dts
> +++ b/arch/arm/boot/dts/omap4-panda-es.dts
> @@ -10,6 +10,11 @@
> #include "omap4460.dtsi"
> #include "omap4-panda-common.dtsi"
>
> +/ {
> + model = "TI OMAP4 PandaBoard-ES";
> + compatible = "ti,omap4-panda-es", "ti,omap4-panda", "ti,omap4460", "ti,omap4430", "ti,omap4";
> +};
> +
> /* Audio routing is differnet between PandaBoard4430 and PandaBoardES */
> &sound {
> ti,model = "PandaBoardES";
> diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts
> index 6189a8b..a0e28b2 100644
> --- a/arch/arm/boot/dts/omap4-panda.dts
> +++ b/arch/arm/boot/dts/omap4-panda.dts
> @@ -9,3 +9,8 @@
>
> #include "omap443x.dtsi"
> #include "omap4-panda-common.dtsi"
> +
> +/ {
> + model = "TI OMAP4 PandaBoard";
> + compatible = "ti,omap4-panda", "ti,omap4430", "ti,omap4";
> +};
> --
> 1.7.9.5
>
prev parent reply other threads:[~2014-09-03 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 20:45 [PATCH] ARM: dts: omap4-panda: Fix model and SoC family details Nishanth Menon
2014-09-03 21:27 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903212732.GI11766@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).