* [PATCH 0/2] ARM: dts: dra7-evm: fixes for mux and VTT control
@ 2014-09-04 13:23 Nishanth Menon
2014-09-04 13:23 ` [PATCH 1/2] ARM: dts: dra7-evm: Fix spi1 mux documentation Nishanth Menon
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Nishanth Menon @ 2014-09-04 13:23 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap, rogerq, Lokesh Vutla, devicetree, linux-arm-kernel,
linux-kernel, Nishanth Menon
Hi,
The following series was inspired in part by http://marc.info/?l=linux-omap&m=140974309205295&w=2
causing me to try and do an audit of pinctrl configurations on the platform.
Further, failures on latest board updates in the automated farm also
caused identification of a fix which was yet to be send to upstream
from product kernel. Slightly unrelated patches in this series.
So here they are..
based on v3.17-rc1:
before-dra7xx-evm: Boot FAIL: http://paste.ubuntu.org.cn/1477597
(fails can be at different times though.. random crashes without VTT is usual)..
after-dra7xx-evm: Boot PASS: http://paste.ubuntu.org.cn/1477596
Lokesh Vutla (1):
ARM: dts: dra7-evm: Add vtt regulator support
Nishanth Menon (1):
ARM: dts: dra7-evm: Fix spi1 mux documentation
arch/arm/boot/dts/dra7-evm.dts | 39 ++++++++++++++++++++++++++++++++-------
1 file changed, 32 insertions(+), 7 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] ARM: dts: dra7-evm: Fix spi1 mux documentation 2014-09-04 13:23 [PATCH 0/2] ARM: dts: dra7-evm: fixes for mux and VTT control Nishanth Menon @ 2014-09-04 13:23 ` Nishanth Menon 2014-09-04 13:33 ` Nishanth Menon 2014-09-04 13:23 ` [PATCH 2/2] ARM: dts: dra7-evm: Add vtt regulator support Nishanth Menon [not found] ` <1409837008-32144-1-git-send-email-nm-l0cyMroinI0@public.gmane.org> 2 siblings, 1 reply; 5+ messages in thread From: Nishanth Menon @ 2014-09-04 13:23 UTC (permalink / raw) To: Tony Lindgren Cc: linux-omap, rogerq, Lokesh Vutla, devicetree, linux-arm-kernel, linux-kernel, Nishanth Menon While auditing the various pin ctrl configurations using the following command: grep PIN_ arch/arm/boot/dts/dra7-evm.dts|(while read line; do v=`echo "$line" | sed -e "s/\s\s*/|/g" | cut -d '|' -f1 | cut -d 'x' -f2|tr [a-z] [A-Z]`; HEX=`echo "obase=16;ibase=16;4A003400+$v"| bc`; echo "$HEX ===> $line"; done) against DRA75x/74x NDA TRM revision S(SPRUHI2S August 2014), documentation errors were found for spi1 pinctrl. Fix the same. Fixes: 6e58b8f1daaf1af340fb9309907e5ffa473c7aff ("ARM: dts: DRA7: Add the dts files for dra7 SoC and dra7-evm board") Signed-off-by: Nishanth Menon <nm@ti.com> --- arch/arm/boot/dts/dra7-evm.dts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index 50f8022..e120fca 100644 --- a/arch/arm/boot/dts/dra7-evm.dts +++ b/arch/arm/boot/dts/dra7-evm.dts @@ -50,13 +50,13 @@ mcspi1_pins: pinmux_mcspi1_pins { pinctrl-single,pins = < - 0x3a4 (PIN_INPUT | MUX_MODE0) /* spi2_clk */ - 0x3a8 (PIN_INPUT | MUX_MODE0) /* spi2_d1 */ - 0x3ac (PIN_INPUT | MUX_MODE0) /* spi2_d0 */ - 0x3b0 (PIN_INPUT_SLEW | MUX_MODE0) /* spi2_cs0 */ - 0x3b4 (PIN_INPUT_SLEW | MUX_MODE0) /* spi2_cs1 */ - 0x3b8 (PIN_INPUT_SLEW | MUX_MODE6) /* spi2_cs2 */ - 0x3bc (PIN_INPUT_SLEW | MUX_MODE6) /* spi2_cs3 */ + 0x3a4 (PIN_INPUT | MUX_MODE0) /* spi1_sclk */ + 0x3a8 (PIN_INPUT | MUX_MODE0) /* spi1_d1 */ + 0x3ac (PIN_INPUT | MUX_MODE0) /* spi1_d0 */ + 0x3b0 (PIN_INPUT_SLEW | MUX_MODE0) /* spi1_cs0 */ + 0x3b4 (PIN_INPUT_SLEW | MUX_MODE0) /* spi1_cs1 */ + 0x3b8 (PIN_INPUT_SLEW | MUX_MODE6) /* spi1_cs2.hdmi1_hpd */ + 0x3bc (PIN_INPUT_SLEW | MUX_MODE6) /* spi1_cs3.hdmi1_cec */ >; }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: dts: dra7-evm: Fix spi1 mux documentation 2014-09-04 13:23 ` [PATCH 1/2] ARM: dts: dra7-evm: Fix spi1 mux documentation Nishanth Menon @ 2014-09-04 13:33 ` Nishanth Menon 0 siblings, 0 replies; 5+ messages in thread From: Nishanth Menon @ 2014-09-04 13:33 UTC (permalink / raw) To: Tony Lindgren Cc: linux-omap, rogerq, Lokesh Vutla, devicetree, linux-arm-kernel, linux-kernel On 08:23-20140904, Nishanth Menon wrote: > While auditing the various pin ctrl configurations using the following > command: > grep PIN_ arch/arm/boot/dts/dra7-evm.dts|(while read line; > do > v=`echo "$line" | sed -e "s/\s\s*/|/g" | cut -d '|' -f1 | > cut -d 'x' -f2|tr [a-z] [A-Z]`; > HEX=`echo "obase=16;ibase=16;4A003400+$v"| bc`; > echo "$HEX ===> $line"; > done) > against DRA75x/74x NDA TRM revision S(SPRUHI2S August 2014), > documentation errors were found for spi1 pinctrl. Fix the same. > > Fixes: 6e58b8f1daaf1af340fb9309907e5ffa473c7aff ("ARM: dts: DRA7: Add > the dts files for dra7 SoC and dra7-evm board") ^^^ uggh... apologies.. checkpatch slipped this one.. updated rev below (wont repost unless requested), Apologies on the spam.. ----8<---- >From db595b941663f634f5f5106cf0092c7c8e998bb4 Mon Sep 17 00:00:00 2001 From: Nishanth Menon <nm@ti.com> Date: Thu, 4 Sep 2014 08:06:27 -0500 Subject: [PATCH V2 1/2] ARM: dts: dra7-evm: Fix spi1 mux documentation While auditing the various pin ctrl configurations using the following command: grep PIN_ arch/arm/boot/dts/dra7-evm.dts|(while read line; do v=`echo "$line" | sed -e "s/\s\s*/|/g" | cut -d '|' -f1 | cut -d 'x' -f2|tr [a-z] [A-Z]`; HEX=`echo "obase=16;ibase=16;4A003400+$v"| bc`; echo "$HEX ===> $line"; done) against DRA75x/74x NDA TRM revision S(SPRUHI2S August 2014), documentation errors were found for spi1 pinctrl. Fix the same. Fixes: 6e58b8f1daaf1af ("ARM: dts: DRA7: Add the dts files for dra7 SoC and dra7-evm board") Signed-off-by: Nishanth Menon <nm@ti.com> --- arch/arm/boot/dts/dra7-evm.dts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index 50f8022..e120fca 100644 --- a/arch/arm/boot/dts/dra7-evm.dts +++ b/arch/arm/boot/dts/dra7-evm.dts @@ -50,13 +50,13 @@ mcspi1_pins: pinmux_mcspi1_pins { pinctrl-single,pins = < - 0x3a4 (PIN_INPUT | MUX_MODE0) /* spi2_clk */ - 0x3a8 (PIN_INPUT | MUX_MODE0) /* spi2_d1 */ - 0x3ac (PIN_INPUT | MUX_MODE0) /* spi2_d0 */ - 0x3b0 (PIN_INPUT_SLEW | MUX_MODE0) /* spi2_cs0 */ - 0x3b4 (PIN_INPUT_SLEW | MUX_MODE0) /* spi2_cs1 */ - 0x3b8 (PIN_INPUT_SLEW | MUX_MODE6) /* spi2_cs2 */ - 0x3bc (PIN_INPUT_SLEW | MUX_MODE6) /* spi2_cs3 */ + 0x3a4 (PIN_INPUT | MUX_MODE0) /* spi1_sclk */ + 0x3a8 (PIN_INPUT | MUX_MODE0) /* spi1_d1 */ + 0x3ac (PIN_INPUT | MUX_MODE0) /* spi1_d0 */ + 0x3b0 (PIN_INPUT_SLEW | MUX_MODE0) /* spi1_cs0 */ + 0x3b4 (PIN_INPUT_SLEW | MUX_MODE0) /* spi1_cs1 */ + 0x3b8 (PIN_INPUT_SLEW | MUX_MODE6) /* spi1_cs2.hdmi1_hpd */ + 0x3bc (PIN_INPUT_SLEW | MUX_MODE6) /* spi1_cs3.hdmi1_cec */ >; }; -- 1.7.9.5 -- Regards, Nishanth Menon ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: dra7-evm: Add vtt regulator support 2014-09-04 13:23 [PATCH 0/2] ARM: dts: dra7-evm: fixes for mux and VTT control Nishanth Menon 2014-09-04 13:23 ` [PATCH 1/2] ARM: dts: dra7-evm: Fix spi1 mux documentation Nishanth Menon @ 2014-09-04 13:23 ` Nishanth Menon [not found] ` <1409837008-32144-1-git-send-email-nm-l0cyMroinI0@public.gmane.org> 2 siblings, 0 replies; 5+ messages in thread From: Nishanth Menon @ 2014-09-04 13:23 UTC (permalink / raw) To: Tony Lindgren Cc: linux-omap, rogerq, Lokesh Vutla, devicetree, linux-arm-kernel, linux-kernel, Nishanth Menon From: Lokesh Vutla <lokeshvutla@ti.com> DRA7 evm REV G and later boards uses a vtt regulator for DDR3 termination and this is controlled by gpio7_11. This gpio is configured in boot loader. gpio7_11, which is only available only on Pad A22, in previous boards, is connected only to an unused pad on expansion connector EXP_P3 and is safe to be muxed as GPIO on all DRA7-evm versions (without a need to spin off another dts file). Since gpio7_11 is used to control VTT and should not be reset or kept in idle state during boot up else VTT will be disconnected and DDR gets corrupted. So, as part of this change, mark gpio7 as no-reset and no-idle on init. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> Signed-off-by: Nishanth Menon <nm@ti.com> --- arch/arm/boot/dts/dra7-evm.dts | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index e120fca..71f0f10 100644 --- a/arch/arm/boot/dts/dra7-evm.dts +++ b/arch/arm/boot/dts/dra7-evm.dts @@ -8,6 +8,7 @@ /dts-v1/; #include "dra74x.dtsi" +#include <dt-bindings/gpio/gpio.h> / { model = "TI DRA742"; @@ -24,9 +25,29 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; }; + + vtt_fixed: fixedregulator-vtt { + compatible = "regulator-fixed"; + regulator-name = "vtt_fixed"; + regulator-min-microvolt = <1350000>; + regulator-max-microvolt = <1350000>; + regulator-always-on; + regulator-boot-on; + enable-active-high; + gpio = <&gpio7 11 GPIO_ACTIVE_HIGH>; + }; }; &dra7_pmx_core { + pinctrl-names = "default"; + pinctrl-0 = <&vtt_pin>; + + vtt_pin: pinmux_vtt_pin { + pinctrl-single,pins = < + 0x3b4 (PIN_OUTPUT | MUX_MODE14) /* spi1_cs1.gpio7_11 */ + >; + }; + i2c1_pins: pinmux_i2c1_pins { pinctrl-single,pins = < 0x400 (PIN_INPUT | MUX_MODE0) /* i2c1_sda */ @@ -54,7 +75,6 @@ 0x3a8 (PIN_INPUT | MUX_MODE0) /* spi1_d1 */ 0x3ac (PIN_INPUT | MUX_MODE0) /* spi1_d0 */ 0x3b0 (PIN_INPUT_SLEW | MUX_MODE0) /* spi1_cs0 */ - 0x3b4 (PIN_INPUT_SLEW | MUX_MODE0) /* spi1_cs1 */ 0x3b8 (PIN_INPUT_SLEW | MUX_MODE6) /* spi1_cs2.hdmi1_hpd */ 0x3bc (PIN_INPUT_SLEW | MUX_MODE6) /* spi1_cs3.hdmi1_cec */ >; @@ -504,3 +524,8 @@ &usb2_phy2 { phy-supply = <&ldousb_reg>; }; + +&gpio7 { + ti,no-reset-on-init; + ti,no-idle-on-init; +}; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <1409837008-32144-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH 0/2] ARM: dts: dra7-evm: fixes for mux and VTT control [not found] ` <1409837008-32144-1-git-send-email-nm-l0cyMroinI0@public.gmane.org> @ 2014-09-04 19:49 ` Tony Lindgren 0 siblings, 0 replies; 5+ messages in thread From: Tony Lindgren @ 2014-09-04 19:49 UTC (permalink / raw) To: Nishanth Menon Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, rogerq-l0cyMroinI0, Lokesh Vutla, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA * Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> [140904 06:24]: > Hi, > > The following series was inspired in part by http://marc.info/?l=linux-omap&m=140974309205295&w=2 > causing me to try and do an audit of pinctrl configurations on the platform. > > Further, failures on latest board updates in the automated farm also > caused identification of a fix which was yet to be send to upstream > from product kernel. Slightly unrelated patches in this series. > > So here they are.. > based on v3.17-rc1: > before-dra7xx-evm: Boot FAIL: http://paste.ubuntu.org.cn/1477597 > (fails can be at different times though.. random crashes without VTT is usual).. > after-dra7xx-evm: Boot PASS: http://paste.ubuntu.org.cn/1477596 Thanks applying both into omap-for-v3.17/fixes-v2. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-04 19:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-04 13:23 [PATCH 0/2] ARM: dts: dra7-evm: fixes for mux and VTT control Nishanth Menon
2014-09-04 13:23 ` [PATCH 1/2] ARM: dts: dra7-evm: Fix spi1 mux documentation Nishanth Menon
2014-09-04 13:33 ` Nishanth Menon
2014-09-04 13:23 ` [PATCH 2/2] ARM: dts: dra7-evm: Add vtt regulator support Nishanth Menon
[not found] ` <1409837008-32144-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-09-04 19:49 ` [PATCH 0/2] ARM: dts: dra7-evm: fixes for mux and VTT control Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).