From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v9 04/12] PCI: OF: Fix the conversion of IO ranges into IO resources. Date: Fri, 5 Sep 2014 16:11:31 -0600 Message-ID: <20140905221131.GJ8080@google.com> References: <1407860725-25202-1-git-send-email-Liviu.Dudau@arm.com> <1407860725-25202-5-git-send-email-Liviu.Dudau@arm.com> <20140822130640.GM13147@bart.dudau.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Rob Herring Cc: Liviu Dudau , Liviu Dudau , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Arnd Bergmann , Russell King , Tanmay Inamdar , Grant Likely , Sinan Kaya , Jingoo Han , Kukjin Kim , Suravee Suthikulanit , linux-pci , linux-arch , Device Tree ML , LKML , LAKML List-Id: devicetree@vger.kernel.org On Sun, Aug 24, 2014 at 06:27:48PM -0500, Rob Herring wrote: > On Fri, Aug 22, 2014 at 8:06 AM, Liviu Dudau wrote: > > mips is doing the same thing and I believe is not affected, pci-host-generic.c > > was adjusting the returned values afterwards so that will not be needed and Lorenzo > > has a patch for the driver to adapt it to this series anyway. > > > > pcie-designware.c also recalculates the io.start and io.end values, so that's fine > > for now. The only ones that I believe are still affected are pci-tegra.c and > > pcie-rcar.c for which I will need to provide a patch similar to integrator unless > > the code gets converted to the new range parsing. > > Well, the latter would be nice, but they certainly have to be fixed. > Now that I think about it, this needs to be handled in a bisectable > way. So I think you need to fix all affected platforms in this patch > rather than a separate patch as you have done. Yep, I was about to complain that the "ARM: integrator: Correct usage of of_pci_range_to_resource()" patch needs to be squashed into whatever broke it, but I see Rob already caught that. Bjorn