From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Magnus Damm <magnus.damm@gmail.com>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding
Date: Sat, 6 Sep 2014 10:21:38 +0900 [thread overview]
Message-ID: <20140906012138.GC16116@verge.net.au> (raw)
In-Reply-To: <7501332.2iGyNsREJQ@avalon>
On Thu, Sep 04, 2014 at 10:00:03AM +0300, Laurent Pinchart wrote:
> Hi Simon,
>
> Thank you for the patch.
>
> On Thursday 04 September 2014 09:55:21 Simon Horman wrote:
> > In general Renesas hardware is not documented to the extent
> > where the relationship between IP blocks on different SoCs can be assumed
> > although they may appear to operate the same way. Furthermore the
> > documentation typically does not specify a version for individual
> > IP blocks. For these reasons a convention of using the SoC name in place
> > of a version and providing SoC-specific compat strings has been adopted.
> >
> > Although not universally liked this convention is used in the bindings
> > for a number of drivers for Renesas hardware. The purpose of this patch is
> > to update the Renesas R-Car Timer Unit (TMU) driver to follow this
> > convention.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > ---
> > * I plan to follow up with a patch patch to use the new binding in the
> > dtsi files for the r8a7779 SoC.
> > commit 471269b790aec03385dc4fb127ed7094ff83c16d
> >
> > v2
> > * Suggestions by Mark Rutland and Sergei Shtylyov
> > - Compatible strings should be "one or more" not "one" of those listed
> > - Describe the generic binding as covering any MTU2 device
> > - Re-order compat strings from most to least specific
> > ---
> > Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> > b/Documentation/devicetree/bindings/timer/renesas,tmu.txt index
> > 425d0c5..f9a9545 100644
> > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> > @@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three
> > channels.
> >
> > Required Properties:
> >
> > - - compatible: must contain "renesas,tmu"
> > + - compatible: must contain one or more of the following:
> > + - "renesas,tmu-r8a7779" R8A7779 TMU
> > + - "renesas,tmu" any TMU
>
> How about matching the wording of patch 1/3 with
>
> - "renesas,tmu-r8a7779" for the R8A7779 TMU
> - "renesas,tmu" for any TMU.
> This is a fallback for the above renesas,tmu-* entries
>
> Same comment for patch 2/3.
>
> With this change,
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, will do.
prev parent reply other threads:[~2014-09-06 1:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 0:55 [PATCH v2 0/3] clocksource: Document Renesas SoC specific bindings Simon Horman
2014-09-04 0:55 ` [PATCH v2 1/3] clocksource: sh_cmt: Document " Simon Horman
2014-09-04 6:51 ` Laurent Pinchart
2014-09-04 6:58 ` Laurent Pinchart
2014-09-06 1:14 ` Simon Horman
2014-09-04 0:55 ` [PATCH v2 2/3] clocksource: sh_mtu2: Document r7s72100 binding Simon Horman
2014-09-04 0:55 ` [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman
2014-09-04 7:00 ` Laurent Pinchart
2014-09-06 1:21 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140906012138.GC16116@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).