From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2] spi: orion: support armada extended baud rates Date: Sat, 6 Sep 2014 09:06:00 -0300 Message-ID: <20140906120600.GA11500@arch.cereza> References: <1409835268-29555-1-git-send-email-gerg@uclinux.org> <5409057A.6090900@uclinux.org> <5409B68A.7010604@uclinux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <5409B68A.7010604-JBU5SbJe1FlAfugRpC6u6w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Ungerer Cc: Geert Uytterhoeven , linux-spi , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jason Cooper , Thomas Petazzoni , Gregory Clement , Andrew Lunn , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hi Greg,=20 (Ccing mvebu guys, full discussion here: http://www.spinics.net/lists/d= evicetree/msg47806.html) On 05 Sep 11:11 PM, Greg Ungerer wrote: > On 05/09/14 17:36, Geert Uytterhoeven wrote: > >No, the other way around (from most-specific to least-specific): > > > > compatible =3D "marvell,armada-spi", "marvell,orion-spi" > > > >So the Armada version is used if available, and the Orion version > >is used as a fallback. Since you are doing another spin, please split this in two patches. The driver and devicetree binding documentation should be in one patch, and the devicetree .dtsi change in another patch. By following Geert's request about the compatible, you make sure both patches can be merged through different maintainers, and that an old de= vicetree blob can be used safely. > > Also what about armada370-xp, armada375, armada380 > >and any other variants out there? >=20 > I don't know. I don't have access to functional specs for anything > other than the 370. I expect they are probably the same though. > (Can anyone confirm?) >=20 Confirmed. Judging from the specs, seems the same SPI IP is on all the Armada SoCs; you can do the 'armada-spi' compatible addition on 375 and= 38x. Did a few tests on the AXP-GP board (which has an SPI flash) using 'orion-spi' and 'armada-spi' compatibles. Tested-by: Ezequiel Garcia Reviewed-by: Ezequiel Garcia I haven't been able to spot any speed difference, though (perhaps my test is too limited?), so I wonder if there's any improvement with this patch? Thanks, --=20 Ezequiel Garc=EDa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html