devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Patches to add dr_mode for dwc2
@ 2014-08-04 13:45 Kever Yang
  2014-08-04 13:45 ` [PATCH v3 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode Kever Yang
  0 siblings, 1 reply; 5+ messages in thread
From: Kever Yang @ 2014-08-04 13:45 UTC (permalink / raw)
  To: Paul Zimmerman
  Cc: dianders, Heiko Stuebner, linux-arm-kernel, addy.ke, cf, xjq,
	olof, sonnyrao, wulf, lyz, jg1.han, hj, huangtao, Kever Yang,
	devicetree, Matt Porter, Paul Zimmerman, linux-usb, Kumar Gala,
	Stephen Warren, linux-kernel, Ian Campbell, Rob Herring,
	Pawel Moll, Greg Kroah-Hartman, Felipe Balbi, Mark Rutland

These two patches enable the dr_mode for the dwc2 usb
controller.  These are split from the patch series adding
rk3288 dwc2 support.

Changes in v3:
- fix the odd spacing in dwc2_hsotg struct
- From Jingoo's suggestion:
    change the commit message

Changes in v2:
- Split out dr_mode and rk3288 bindings.
- put spaces around '+' operator
- expand the comment for dr_mode
- handle dr_mode is USB_DR_MODE_OTG

Kever Yang (2):
  Documentation: dt-bindings: add dt binding info for dwc2 dr_mode
  usb: dwc2: add 'mode' which based on Kconfig select or dts setting

 Documentation/devicetree/bindings/usb/dwc2.txt |  2 ++
 drivers/usb/dwc2/core.c                        | 18 ++++++++++++++++++
 drivers/usb/dwc2/core.h                        |  5 +++++
 drivers/usb/dwc2/platform.c                    | 12 ++++++++++++
 4 files changed, 37 insertions(+)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode
  2014-08-04 13:45 [PATCH v3 0/2] Patches to add dr_mode for dwc2 Kever Yang
@ 2014-08-04 13:45 ` Kever Yang
  2014-08-04 16:20   ` Doug Anderson
       [not found]   ` <1407159942-7063-2-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  0 siblings, 2 replies; 5+ messages in thread
From: Kever Yang @ 2014-08-04 13:45 UTC (permalink / raw)
  To: Paul Zimmerman
  Cc: dianders, Heiko Stuebner, linux-arm-kernel, addy.ke, cf, xjq,
	olof, sonnyrao, wulf, lyz, jg1.han, hj, huangtao, Kever Yang,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Greg Kroah-Hartman, Matt Porter, Paul Zimmerman, Felipe Balbi,
	Stephen Warren, devicetree, linux-kernel

Indicate that the generic dr_mode binding should be used for dwc2.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v3: None
Changes in v2:
- Split out dr_mode and rk3288 bindings.

 Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
index 467ddd1..3cf92b6 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.txt
+++ b/Documentation/devicetree/bindings/usb/dwc2.txt
@@ -15,6 +15,8 @@ Optional properties:
 - phys: phy provider specifier
 - phy-names: shall be "usb2-phy"
 Refer to phy/phy-bindings.txt for generic phy consumer properties
+- dr_mode: shall be one of "host", "peripheral" and "otg"
+  Refer to usb/generic.txt
 
 Example:
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode
  2014-08-04 13:45 ` [PATCH v3 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode Kever Yang
@ 2014-08-04 16:20   ` Doug Anderson
       [not found]   ` <1407159942-7063-2-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Doug Anderson @ 2014-08-04 16:20 UTC (permalink / raw)
  To: Kever Yang
  Cc: Paul Zimmerman, Heiko Stuebner, linux-arm-kernel, Addy Ke,
	Eddie Cai, Jianqun Xu, Olof Johansson, Sonny Rao, wulf, lyz,
	Jingoo Han, han jiang, Tao Huang, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Greg Kroah-Hartman,
	Matt Porter, Paul Zimmerman, Felipe Balbi, Stephen Warren,
	devicetree@vger.kernel.org

Kever,

On Mon, Aug 4, 2014 at 6:45 AM, Kever Yang <kever.yang@rock-chips.com> wrote:
> Indicate that the generic dr_mode binding should be used for dwc2.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v3: None

Since I gave my Reviewed-by tag for v2 and you made no changes from v2
to v3, you should make sure you include my Reviewed-by tag in the new
version.

Reviewed-by: Doug Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode
       [not found]   ` <1407159942-7063-2-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2014-09-08 18:50     ` Doug Anderson
       [not found]       ` <CAD=FV=WDv9Pxe+jSqsfARPvjxMWPfcVpPMk1wHCgOO8ePiCh3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Doug Anderson @ 2014-09-08 18:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Paul Zimmerman, Heiko Stuebner,
	linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA, Addy Ke, Eddie Cai,
	Jianqun Xu, Olof Johansson, Sonny Rao, wulf, lyz, Jingoo Han,
	han jiang, Tao Huang, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Matt Porter, Paul Zimmerman,
	Felipe Balbi, Stephen Warren,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kever Yang

Greg,

On Mon, Aug 4, 2014 at 6:45 AM, Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote:
> Indicate that the generic dr_mode binding should be used for dwc2.
>
> Signed-off-by: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Split out dr_mode and rk3288 bindings.
>
>  Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
>  1 file changed, 2 insertions(+)

Are there any other changes you'd like for this patch (and the next
one that goes with it) before landing?

Thanks!

-Doug
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode
       [not found]       ` <CAD=FV=WDv9Pxe+jSqsfARPvjxMWPfcVpPMk1wHCgOO8ePiCh3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-09-08 21:31         ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2014-09-08 21:31 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Paul Zimmerman, Heiko Stuebner,
	linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA, Addy Ke, Eddie Cai,
	Jianqun Xu, Olof Johansson, Sonny Rao, wulf, lyz, Jingoo Han,
	han jiang, Tao Huang, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Matt Porter, Paul Zimmerman,
	Felipe Balbi, Stephen Warren,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kever Yang

On Mon, Sep 08, 2014 at 11:50:25AM -0700, Doug Anderson wrote:
> Greg,
> 
> On Mon, Aug 4, 2014 at 6:45 AM, Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote:
> > Indicate that the generic dr_mode binding should be used for dwc2.
> >
> > Signed-off-by: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> > ---
> >
> > Changes in v3: None
> > Changes in v2:
> > - Split out dr_mode and rk3288 bindings.
> >
> >  Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Are there any other changes you'd like for this patch (and the next
> one that goes with it) before landing?

No idea, please resend.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-09-08 21:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 13:45 [PATCH v3 0/2] Patches to add dr_mode for dwc2 Kever Yang
2014-08-04 13:45 ` [PATCH v3 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode Kever Yang
2014-08-04 16:20   ` Doug Anderson
     [not found]   ` <1407159942-7063-2-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-08 18:50     ` Doug Anderson
     [not found]       ` <CAD=FV=WDv9Pxe+jSqsfARPvjxMWPfcVpPMk1wHCgOO8ePiCh3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-08 21:31         ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).