From: Mark Rutland <mark.rutland@arm.com>
To: Stefan Wahren <info@lategoodbye.de>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 1/3] DT: add binding for MXS regulator
Date: Tue, 9 Sep 2014 18:59:40 +0100 [thread overview]
Message-ID: <20140909175940.GF3896@leverpostej> (raw)
In-Reply-To: <1410089869-6611-2-git-send-email-info@lategoodbye.de>
On Sun, Sep 07, 2014 at 12:37:47PM +0100, Stefan Wahren wrote:
> This patch adds the Device tree bindings for the Freescale MXS on-chip
> regulators.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> .../bindings/regulator/mxs-regulator.txt | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mxs-regulator.txt
>
> diff --git a/Documentation/devicetree/bindings/regulator/mxs-regulator.txt b/Documentation/devicetree/bindings/regulator/mxs-regulator.txt
> new file mode 100644
> index 0000000..c3226cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mxs-regulator.txt
> @@ -0,0 +1,38 @@
> +MXS regulators
> +
> +Required node properties:
> +- compatible: Should be "fsl,<soc>-power", where soc is "imx23" or "imx28"
> +- reg: Offset and length of the register set for the device
We require #address-cells and #size-cells if the child nodes have reg
entries.
> +
> +Required regulator properties:
> +- compatible: Must be "fsl,mxs-regulator"
> +- reg: Offset of the register set for the regulator
Is this the offset or the absolute physical address?
The example seems to be absolute.
> +- mxs-max-reg-val: Maximum value of this register
What does this even mean? What's the format?
Is this not implied by standard properties like regulator-max-microvolt?
> +Optional regulator properties:
> +- mxs-default-microvolt: initial voltage of the regulator
Why is this necessary?
Mark.
> +
> +Any regulator property defined as part of the core regulator
> +binding, defined in regulator.txt, can also be used.
> +
> +Example:
> +
> + power: power@80044000 {
> + compatible = "fsl,imx28-power";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x80044000 0x2000>;
> +
> + reg_vddio: regulator-vddio@80044060 {
> + reg = <0x80044060>;
> + compatible = "fsl,mxs-regulator";
> + regulator-name = "vddio";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <3600000>;
> + regulator-microvolt-offset = <80000>;
> + regulator-always-on;
> + mxs-max-reg-val = <0x10>;
> + mxs-default-microvolt = <3300000>;
> + };
> + };
> +
> --
> 1.8.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2014-09-09 17:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 11:37 [PATCH RFC 0/3] ARM: regulator: add Freescale MXS regulator driver Stefan Wahren
2014-09-07 11:37 ` [PATCH RFC 1/3] DT: add binding for MXS regulator Stefan Wahren
2014-09-07 13:35 ` Sergei Shtylyov
2014-09-09 17:59 ` Mark Rutland [this message]
2014-09-09 18:48 ` Stefan Wahren
2014-09-07 11:37 ` [PATCH RFC 2/3] ARM: regulator: add Freescale MXS regulator driver Stefan Wahren
[not found] ` <1410089869-6611-3-git-send-email-info-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2014-09-09 18:22 ` Mark Rutland
2014-09-09 19:17 ` Stefan Wahren
[not found] ` <540F523D.4010904-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2014-09-10 14:18 ` Mark Rutland
2014-09-10 15:13 ` Mark Brown
2014-09-10 17:32 ` Stefan Wahren
2014-09-10 18:54 ` Fabio Estevam
[not found] ` <CAOMZO5BEN_DQOyhrx5ZB7y6DoDvqbLvDyJfAabOvtUvKOiGHOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-11 5:53 ` Stefan Wahren
[not found] ` <54108B34.6010701-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2014-09-10 19:50 ` Mark Brown
2014-09-10 17:24 ` Stefan Wahren
[not found] ` <54108939.5050208-hi6Y0CQ0nG0@public.gmane.org>
2014-09-10 17:06 ` Fabio Estevam
2014-09-07 11:37 ` [PATCH RFC 3/3] DT: ARM: mxs: enable regulator support for i.MX28 Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909175940.GF3896@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=info@lategoodbye.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).