Re: [PATCH V3] pwm: lpc32xx - Add a driver for the motor PWM

[Alban Bedel <alban.bedel-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

On Tue, 09 Sep 2014 17:47:53 +0200
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:

> On Tuesday 09 September 2014 17:42:41 Alban Bedel wrote:
> > +config PWM_LPC32XX_MOTOR
> > +	tristate "LPC32xx Motor PWM support"
> > +	depends on ARCH_LPC32XX
> > +	help
> > +	  Generic PWM framework driver for LPC32xx motor PWM. The LPC32xx SOC
> > +	  has one motor PWM controllers.
> > +
> > +	  To compile this driver as a module, choose M here: the module
> > +	  will be called pwm-lpc32xx-motor.
> > +
> 
> Can you change the dependency to ARCH_LPC32XX || COMPILE_TEST and
> add explicit dependencies for the subsystems the driver depends
> on (pwm and clk, I guess)? That would give us better build-time
> coverage with allmodconfig.

I'll add COMPILE_TEST, PWM is already there because this is in an if
PWM block. However I'm not sure for the clk, the LPC32xx use its own
implementation of the clk functions, what should I add in this case?

> > +	/* Write to limit register -> period */
> > +	__raw_writel(period, lpc32xx->base + MCLIM_REG_OFFSET(pwm));
> > +
> > +	/* Write to match register -> duty */
> > +	__raw_writel(period - duty, lpc32xx->base + MCMAT_REG_OFFSET(pwm));
> 
> Please don't use __raw_{writel,readl} in driver, and change that to use
> readl_relaxed()/writel_relaxed().

Will do.

Alban

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]