* [PATCH] checkpatch: struct of_device_id should usually be const
@ 2014-09-10 7:15 Uwe Kleine-König
[not found] ` <1410333346-29062-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2014-09-10 7:15 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches
Cc: linux-kernel, kernel, Grant Likely, Rob Herring, devicetree
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b385bcbbf2f5..01f503e0ebbd 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4941,6 +4941,7 @@ sub process {
mtrr_ops|
neigh_ops|
nlmsvc_binding|
+ of_device_id|
pci_raw_ops|
pipe_buf_operations|
platform_hibernation_ops|
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1410333346-29062-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH] checkpatch: struct of_device_id should usually be const [not found] ` <1410333346-29062-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2014-09-10 7:23 ` Joe Perches 2014-09-10 7:29 ` Uwe Kleine-König 0 siblings, 1 reply; 3+ messages in thread From: Joe Perches @ 2014-09-10 7:23 UTC (permalink / raw) To: Uwe Kleine-König Cc: Andy Whitcroft, linux-kernel-u79uwXL29TY76Z2rM5mHXA, kernel-bIcnvbaLZ9MEGnE8C9+IrQ, Grant Likely, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA On Wed, 2014-09-10 at 09:15 +0200, Uwe Kleine-König wrote: > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -4941,6 +4941,7 @@ sub process { > mtrr_ops| > neigh_ops| > nlmsvc_binding| > + of_device_id| > pci_raw_ops| > pipe_buf_operations| > platform_hibernation_ops| Fine by me, there are ~1200 or so const uses. There are also ~350 of these that are not const. Are most all of those supposed to be const? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] checkpatch: struct of_device_id should usually be const 2014-09-10 7:23 ` Joe Perches @ 2014-09-10 7:29 ` Uwe Kleine-König 0 siblings, 0 replies; 3+ messages in thread From: Uwe Kleine-König @ 2014-09-10 7:29 UTC (permalink / raw) To: Joe Perches Cc: Andy Whitcroft, linux-kernel, kernel, Grant Likely, Rob Herring, devicetree On Wed, Sep 10, 2014 at 12:23:17AM -0700, Joe Perches wrote: > On Wed, 2014-09-10 at 09:15 +0200, Uwe Kleine-König wrote: > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -4941,6 +4941,7 @@ sub process { > > mtrr_ops| > > neigh_ops| > > nlmsvc_binding| > > + of_device_id| > > pci_raw_ops| > > pipe_buf_operations| > > platform_hibernation_ops| > > Fine by me, there are ~1200 or so const uses. > > There are also ~350 of these that are not const. > > Are most all of those supposed to be const? Yeah, I'm working on a patch series to fix most of these. I thought I sent out the checkpatch patch first to slow down the occurences to fix. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-10 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-10 7:15 [PATCH] checkpatch: struct of_device_id should usually be const Uwe Kleine-König
[not found] ` <1410333346-29062-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-09-10 7:23 ` Joe Perches
2014-09-10 7:29 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).