From: Alban Bedel <alban.bedel@avionic-design.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alban Bedel <alban.bedel@avionic-design.de>,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pwm@vger.kernel.org, Grant Likely <grant.likely@linaro.org>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
Roland Stigge <stigge@antcom.de>
Subject: Re: [PATCH V4] pwm: lpc32xx - Add a driver for the motor PWM
Date: Thu, 11 Sep 2014 10:36:21 +0200 [thread overview]
Message-ID: <20140911103621.198f7ef6@avionic-0020> (raw)
In-Reply-To: <3043402.gA1yIrlkCZ@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On Wed, 10 Sep 2014 18:28:39 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 10 September 2014 17:59:41 Alban Bedel wrote:
> > On Wed, 10 Sep 2014 17:51:36 +0200
> > Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > > On Wednesday 10 September 2014 17:43:42 Alban Bedel wrote:
> > > > +- #pwm-cells: should be 3. See pwm.txt in this directory for a description of
> > > > + the cells format. The only third cell flag supported by this binding is
> > > > + PWM_POLARITY_INVERTED.
> > >
> > > If you don't have multiple pwm outputs or programmable period, I would say it
> > > should use #pwm-cells=<1> and only pass the polarity.
> >
> > There is 3 channel, so 3 PWM from the API POV, and the period is
> > independently programmable for each one.
>
> Then you should put the channel number into the first cell and the period
> length into the second cell, as the pwm.txt document says.
That's what is implemented in this patch, by using
of_pwm_xlate_with_flags() for the .of_xlate callback.
Alban
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-11 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 15:43 [PATCH V4] pwm: lpc32xx - Add a driver for the motor PWM Alban Bedel
2014-09-10 15:51 ` Arnd Bergmann
2014-09-10 15:59 ` Alban Bedel
2014-09-10 16:28 ` Arnd Bergmann
2014-09-11 8:36 ` Alban Bedel [this message]
2014-09-11 9:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911103621.198f7ef6@avionic-0020 \
--to=alban.bedel@avionic-design.de \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stigge@antcom.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).