From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH 3/4] regulator/axp20x: use axp2xx consolidated header Date: Thu, 11 Sep 2014 15:26:50 -0700 Message-ID: <20140911152650.74767024@ultegra> References: <1410215046-31751-1-git-send-email-jacob.jun.pan@linux.intel.com> <1410215046-31751-4-git-send-email-jacob.jun.pan@linux.intel.com> <20140909112516.GR2601@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140909112516.GR2601@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: IIO , LKML , DEVICE TREE , Lee Jones , Srinivas Pandruvada , Aaron Lu , Alan Cox , Jean Delvare , Samuel Ortiz , Liam Girdwood , Grant Likely , Greg Kroah-Hartman , Rob Herring , Lars-Peter Clausen , Hartmut Knaack , Fugang Duan , Arnd Bergmann , Zubair Lutfullah , Sebastian Reichel , Johannes Thumshirn , Philippe Reynes , Angelo Compagnucci Doug Anderson List-Id: devicetree@vger.kernel.org On Tue, 9 Sep 2014 12:25:16 +0100 Mark Brown wrote: > On Mon, Sep 08, 2014 at 03:24:05PM -0700, Jacob Pan wrote: > > AXP20x driver has been extended to support axp288 variant. Header > > file and common data structures has also been renamed to suit the > > new scope of devices supported. > > > > This patch makes use of the renamed header and structure. > > > -#include > > +#include > > Acked-by: Mark Brown > > but is it really worth the effort of renaming everything? That's > going to cause problems for things like the stable workflow. sorry for the late reply. IMHO, consistent and correct naming has longer term benefit. how can i help to make the stable workflow easier?