From: David Miller <davem@davemloft.net>
To: Frank.Li@freescale.com
Cc: b38611@freescale.com, netdev@vger.kernel.org, lznuaa@gmail.com,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux@arm.linux.org.uk
Subject: Re: [Patch v3 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement
Date: Fri, 12 Sep 2014 16:40:47 -0400 (EDT) [thread overview]
Message-ID: <20140912.164047.810313458974612565.davem@davemloft.net> (raw)
In-Reply-To: <1410373845-5801-10-git-send-email-Frank.Li@freescale.com>
From: Frank Li <Frank.Li@freescale.com>
Date: Thu, 11 Sep 2014 02:30:42 +0800
> +
> + unsigned tx_align;
> + unsigned rx_align;
> };
Please always fully write out "unsigned int" rather than just "unsigned".
> @@ -2399,6 +2393,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
> struct sk_buff *skb;
> struct bufdesc *bdp;
> struct fec_enet_priv_rx_q *rxq;
> + unsigned off;
Likewise.
next prev parent reply other threads:[~2014-09-12 20:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 18:30 [Patch v3 net-next 00/12] net: fec: imx6sx multiqueue support Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 01/12] net:fec: add enet refrence clock for i.MX 6SX chip Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 02/12] net:fec: add enet AVB feature macro define for imx6sx Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 03/12] net: fec: change data structure to support multiqueue Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 04/12] net: fec: parser max queue number from dt file Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 05/12] net: fec: init multi queue date structure Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 06/12] net:fec: Disable enet-avb MAC instead of reset MAC Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 07/12] net: fec: add enet-avb IP support Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 08/12] net:fec: Add fsl,imx6sx-fec compatible strings Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement Frank Li
2014-09-12 20:40 ` David Miller [this message]
2014-09-12 20:45 ` Zhi Li
[not found] ` <1410373845-5801-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-09-10 18:30 ` [Patch v3 net-next 10/12] net: fec: init complete variable in early to avoid kernel dump Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 11/12] ARM: Documentation: Update fec dts binding doc Frank Li
2014-09-10 18:30 ` [Patch v3 net-next 12/12] ARM: dts: imx6sx: add multi-queue support enet Frank Li
[not found] <1410373813-5731-1-git-send-email-yes>
2014-09-10 18:30 ` [Patch v3 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement yes
2014-09-10 18:30 ` yes-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912.164047.810313458974612565.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Frank.Li@freescale.com \
--cc=b38611@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).