From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver Date: Fri, 12 Sep 2014 15:29:43 -0500 Message-ID: <20140912202942.GC25500@saruman.home> References: <1410550088-8754-1-git-send-email-agross@codeaurora.org> <1410550088-8754-3-git-send-email-agross@codeaurora.org> <20140912202008.GB25500@saruman.home> <541356CE.1020902@smartplayin.com> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dkEUBIird37B8yKS" Return-path: Content-Disposition: inline In-Reply-To: <541356CE.1020902@smartplayin.com> Sender: linux-kernel-owner@vger.kernel.org To: Pramod Gurav Cc: balbi@ti.com, Pramod Gurav , Andy Gross , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Kishon Vijay Abraham I , Jack Pham , Kumar Gala , linux-arm-msm , linux-usb@vger.kernel.org, "Ivan T. Ivanov" , Bjorn Andersson List-Id: devicetree@vger.kernel.org --dkEUBIird37B8yKS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Sep 13, 2014 at 01:55:50AM +0530, Pramod Gurav wrote: > >>> + qdwc =3D devm_kzalloc(&pdev->dev, sizeof(*qdwc), GFP_KERNEL); > >>> + if (!qdwc) > >>> + return -ENOMEM; > >>> + > >>> + platform_set_drvdata(pdev, qdwc); > >>> + > >>> + qdwc->dev =3D &pdev->dev; > >>> + > >>> + qdwc->core_clk =3D devm_clk_get(qdwc->dev, "core"); > >>> + if (IS_ERR(qdwc->core_clk)) { > >>> + dev_err(qdwc->dev, "failed to get core clock\n"); > >>> + return PTR_ERR(qdwc->core_clk); > >>> + } > >>> + > >>> + qdwc->iface_clk =3D devm_clk_get(qdwc->dev, "iface"); > >>> + if (IS_ERR(qdwc->iface_clk)) { > >>> + dev_dbg(qdwc->dev, "failed to get optional iface cloc= k\n"); > >>> + qdwc->iface_clk =3D NULL; > >>> + } > >>> + > >>> + qdwc->sleep_clk =3D devm_clk_get(qdwc->dev, "sleep"); > >>> + if (IS_ERR(qdwc->sleep_clk)) { > >>> + dev_dbg(qdwc->dev, "failed to get optional sleep cloc= k\n"); > >>> + qdwc->sleep_clk =3D NULL; > >>> + } > >>> + > >>> + ret =3D clk_prepare_enable(qdwc->core_clk); > >>> + if (ret) { > >>> + dev_err(qdwc->dev, "failed to enable core clock\n"); > >>> + goto err_core; > >>> + } > >>> + > >>> + ret =3D clk_prepare_enable(qdwc->iface_clk); > >>> > >> Should not we check if qdwc->iface_clk is valid? > >=20 > > read the sources luke. > Now I read that its initialized to NULL in fail case but should we call > prepare_enable at all if its NULL? now read the source of clk_enable() and clk_prepare() ;-) NULL is a valid clock, it just returns 0. This is better than sprinkling IS_ERR() all over the place. --=20 balbi --dkEUBIird37B8yKS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUE1e2AAoJEIaOsuA1yqREJzsP/3F+k9wovz/FojoYLqJ4n99e RyUr85Wxne41OspspC4UptVzq9RcS7CEZp/2hSTF5iYoL6CNSupZq72vkgX5s16S sPsBCEtUVSu0MrQFGfM8UJP0Rw7K9qgKls6HSyPfznmDJDn5TFdNSbDJQf85dFFr WhrkofOxGwMSOMahnkCZ1LlqHw3k0OcbPNPs3inuKI7xEw/XpzPCRb3oBPMZLGzD FoGMb6U7sl9Nwe+w+sMmNCtPUIG5il5gUPETRdKhfD7BnH6Dzgu+J4VL8q89jCN1 W+ZNOBgH6HcRtIi56ek4nRXCJhplb1wmUB9ri6j/yuZMmhLvvnsfS7S+koYsRt2W J4IwSl72veXqSg+D4kR1QAThrf2dHOHyZNYBDzO7NK3VEAxgka1wQ8Jef33NNX0P oSpXJWJZmbDJCnCCWPEe8+F7OYXFrdlGjbA8XffoAHMujagQOP2sqYJUJu24I4FZ dL4jweAfceeiOLNUvCRDMFQamxAl+8DWAX+Vwjihct/3EfKK/gIj9fNJvvgeIFmm FcRlF2gCIwWuizo4d2QumnmN3L5mN56w2MU2AeB+Ku4do9amOEPOuc2SyDzLufOA 799bhdhdJlDas4AiTaZ3WlFVbeGoWdoJByzeGYri8P60VsnP/Y4XJICC4R+8LUsz wtWT965SNKPgToY35hr4 =W/XX -----END PGP SIGNATURE----- --dkEUBIird37B8yKS--