From: Antoine Tenart <antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Antoine Tenart
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Tue, 16 Sep 2014 16:05:51 +0200 [thread overview]
Message-ID: <20140916140551.GE4869@kwain> (raw)
In-Reply-To: <20140916133841.GA4869@kwain>
On Tue, Sep 16, 2014 at 03:38:41PM +0200, Antoine Tenart wrote:
> On Tue, Sep 16, 2014 at 08:51:30AM +0800, Peter Chen wrote:
> > On Mon, Sep 15, 2014 at 12:36:13PM +0200, Antoine Tenart wrote:
> > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock
> > > and DMA mask, to support USB2 ChipIdea controllers that don't need
> > > specific functions.
> > >
> > > Tested on the Marvell Berlin SoCs USB controllers.
> > >
> > > Signed-off-by: Antoine Tenart <antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> > > ---
> > > drivers/usb/chipidea/Makefile | 1 +
> > > drivers/usb/chipidea/ci_hdrc_usb2.c | 137 ++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 138 insertions(+)
> > > create mode 100644 drivers/usb/chipidea/ci_hdrc_usb2.c
> > >
> >
> > compile error:
> >
> > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c: In function 'ci_hdrc_usb2_dt_probe':
> > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30:2: error: implicit declaration of function 'of_phy_get' [-Werror=implicit-function-declaration]
> > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30:16: warning: assignment makes pointer from integer without a cast [enabled by default]
>
> Did you apply the series introducing the support for the generic PHY
> framework in the USB subsystem first? One of the patches includes
> 'linux/phy/phy.h' in 'linux/usb/otg.h'. That's why I did not encounter
> this error.
>
> Anyway, you're right and 'linux/phy/phy.h' should be explicitly included
> here.
Let me know if you want me to quickly cook up a new version fixing this.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-16 14:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 10:36 [PATCH v5 00/12] ARM: berlin: USB support Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 01/12] reset: add the Berlin reset controller driver Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 03/12] ARM: Berlin: select the reset controller Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Tenart
[not found] ` <1410777378-12726-1-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-09-15 10:36 ` [PATCH v5 05/12] phy: add the Berlin USB PHY driver Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Tenart
2014-09-16 0:51 ` Peter Chen
2014-09-16 13:38 ` Antoine Tenart
2014-09-16 14:05 ` Antoine Tenart [this message]
2014-09-17 0:00 ` Peter Chen
2014-09-15 10:36 ` [PATCH v5 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Tenart
2014-09-15 10:36 ` [PATCH v5 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916140551.GE4869@kwain \
--to=antoine.tenart-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).