From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robin Gong <b38343@freescale.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
shawn.guo@freescale.com, kernel@pengutronix.de, sre@kernel.org,
dbaryshkov@gmail.com, dwmw2@infradead.org,
grant.likely@linaro.org, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips
Date: Wed, 17 Sep 2014 12:24:20 +0200 [thread overview]
Message-ID: <20140917102420.GW4992@pengutronix.de> (raw)
In-Reply-To: <1410947881-7345-2-git-send-email-b38343@freescale.com>
On Wed, Sep 17, 2014 at 05:57:58PM +0800, Robin Gong wrote:
> All chips of i.mx6 can be powered off by programming SNVS.
> For example :
> On i.mx6q-sabresd board, PMIC_ON_REQ connect with external
> pmic ON/OFF pin, that will cause the whole PMIC powered off
> except VSNVS. And system can restart once PMIC_ON_REQ goes
> high by push POWRER key.
>
> Signed-off-by: Robin Gong <b38343@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 5 +++++
> arch/arm/boot/dts/imx6sl.dtsi | 5 +++++
> arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index c701af9..fffa1c6 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -645,6 +645,11 @@
> interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>,
> <0 20 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + snvs-poweroff@38 {
> + compatible = "fsl,sec-v4.0-poweroff";
> + reg = <0x38 0x4>;
> + };
As said: This makes board specific assumptions on SoC level. Whether or
not this function is available is *BOARD* specific, so at SoC level this
needs a status = "disabled";
So: NACK.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-09-17 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 9:57 [PATCH v3 0/3] add power off driver for i.mx6 Robin Gong
2014-09-17 9:57 ` [PATCH v3 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips Robin Gong
2014-09-17 10:24 ` Sascha Hauer [this message]
2014-09-17 9:57 ` [PATCH v3 2/3] power: reset: imx-snvs-poweroff: add power off driver for i.mx6 Robin Gong
2014-09-17 11:10 ` Lothar Waßmann
2014-09-17 17:52 ` Mark Rutland
2014-09-18 2:21 ` Robin Gong
2014-09-18 17:53 ` Mark Rutland
2014-09-19 6:05 ` Robin Gong
2014-09-17 9:58 ` [PATCH v3 3/3] ARM: configs: imx_v6_v7_defconfig: add power off driver Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917102420.GW4992@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=b38343@freescale.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@freescale.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).