From: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
Date: Wed, 17 Sep 2014 18:55:30 +0200 [thread overview]
Message-ID: <20140917165529.GA24699@earth.universe> (raw)
In-Reply-To: <20140917154400.GE30918@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote:
> On Wed, 17 Sep 2014, Nishanth Menon wrote:
> > ti,system-power-controller is more or less the standard way of
> > indicating that the PMIC is the system wide power controller and hence
> > may be used to switch off the system. Almost ALL TI PMIC drivers and
> > many Maxim PMIC drivers follow the same style.
> >
> > So support 'ti,system-power-controller' in addition to the usual
> > 'ti,use_poweroff' to indicate that the PMIC instance has control for
> > switching off the system.
> >
> > Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
> > ---
> >
> > V2: picked up documentation suggestion from Sebastien
>
> It would be good to get Sebastian's Ack.
Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[...]
> > +- ti,system-power-controller: This indicates that TWL4030 is the
> > + power supply master of the system. With this flag, the chip will
> > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> > + system poweroffs.
One minor thing: While the documentation is updated you may want to
fix the typo "will initiates" to "will initiate" (or just drop the
"will").
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-17 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 12:34 [PATCH V2 0/2] mfd: twl4030-power: support ti,system-power-controller Nishanth Menon
[not found] ` <1410957252-764-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-09-17 12:34 ` [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Nishanth Menon
2014-09-17 15:44 ` Lee Jones
2014-09-17 16:55 ` Sebastian Reichel [this message]
[not found] ` <20140917165529.GA24699-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2014-09-17 17:01 ` Nishanth Menon
2014-09-17 21:39 ` Lee Jones
2014-09-17 12:34 ` [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off Nishanth Menon
[not found] ` <1410957252-764-3-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-09-17 21:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917165529.GA24699@earth.universe \
--to=sre-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).