From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Ganapatrao Kulkarni
<ganapatrao.kulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"open list:OPEN FIRMWARE AND..."
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
linuxppc-dev
<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [RFC PATCH] dt:numa: adding numa node mapping for memory nodes.
Date: Wed, 17 Sep 2014 20:34:52 +0100 [thread overview]
Message-ID: <20140917193452.GD7983@leverpostej> (raw)
In-Reply-To: <A4205FCA-D4DE-48A4-B19F-58400A3FBF5C-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Wed, Sep 17, 2014 at 04:37:30PM +0100, Kumar Gala wrote:
>
> On Sep 17, 2014, at 1:56 AM, Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com> wrote:
>
> > From: Ganapatrao Kulkarni <ganapatrao.kulkarni-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> >
> > This patch adds property "nid" to memory node to provide the memory range to
> > numa node id mapping.
> >
> > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> >
> > —
>
> Adding the PPC guys as they’ve been doing NUMA on IBM Power Servers
> for years with OF/DT. So we should really try and follow what they’ve
> done.
Agreed.
> > Documentation/devicetree/bindings/numa.txt | 58 ++++++++++++++++++++++++++++++
> > 1 file changed, 58 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/numa.txt
> >
> > diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
> > new file mode 100644
> > index 0000000..c4a94f2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/numa.txt
> > @@ -0,0 +1,58 @@
> > +======================================================
> > +numa id binding description
> > +======================================================
> > +
> > +======================================================
> > +1 - Introduction
> > +======================================================
> > +The device node property "nid(numa node id)" can be added to memory
Why the quotes?
> > +device node to map the range of memory addresses as defined in property "reg".
> > +The property "nid" maps the memory range to the numa node id, which is used to
> > +find the local and remory pages on numa aware systems.
What is a "numa node id", exactly, and how is the OS intended to use it?
I don't see how this can be of any use as-is.
Mark.
> > +
> > +======================================================
> > +2 - nid property
> > +======================================================
> > +Numa node id, "nid" is required property of memory device node for
> > +numa enabled platforms.
> > +
> > +|------------------------------------------------------|
> > +|Property Type | Usage | Value Type | Definition |
> > +|------------------------------------------------------|
> > +| nid | R | <u32> | Numa Node id |
> > +| | | | for this memory |
> > +|------------------------------------------------------|
> > +
> > +========================================================
> > +4 - Example memory nodes with numa node id mapping
> > +========================================================
> > +
> > +Example 1 (2 memory nodes, each mapped to a numa node.):
> > +
> > + memory@00000000 {
> > + device_type = "memory";
> > + reg = <0x0 0x00000000 0x0 0x80000000>;
> > + nid = <0x0>;
> > + };
> > +
> > + memory@10000000000 {
> > + device_type = "memory";
> > + reg = <0x100 0x00000000 0x0 0x80000000>;
> > + nid = <0x1>;
> > + };
> > +
> > +Example 2 (multiple memory ranges in each memory node and mapped to numa node):
> > +
> > + memory@00000000 {
> > + device_type = "memory";
> > + reg = <0x0 0x00000000 0x0 0x80000000>,
> > + <0x0 0x80000000 0x0 0x80000000>;
> > + nid = <0x0>;
> > + };
> > +
> > + memory@10000000000 {
> > + device_type = "memory";
> > + reg = <0x100 0x00000000 0x0 0x80000000>,
> > + <0x100 0x80000000 0x0 0x80000000>;
> > + nid = <0x1>;
> > + };
> > --
> > 1.8.1.4
> >
>
> --
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-17 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 8:56 [RFC PATCH] dt:numa: adding numa node mapping for memory nodes Ganapatrao Kulkarni
[not found] ` <1410944189-3608-1-git-send-email-ganapatrao.kulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2014-09-17 15:37 ` Kumar Gala
[not found] ` <A4205FCA-D4DE-48A4-B19F-58400A3FBF5C-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-09-17 19:34 ` Mark Rutland [this message]
2014-10-28 7:27 ` Hanjun Guo
2014-09-17 21:48 ` Nathan Lynch
[not found] ` <541A01B7.8030601-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2014-09-17 23:12 ` Zi Shen Lim
[not found] ` <CAMDttNfSr5BrnEwLXqgy676jOZbFHhXcMtC0n7gBSniwhWCDRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-18 4:02 ` Ganapatrao Kulkarni
[not found] ` <CAFpQJXUs+6Qvj0SqgajA8_D8UdEh_EQVgTQDz0bPSn-VpEty9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-18 14:30 ` Ganapatrao Kulkarni
2014-10-28 7:50 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917193452.GD7983@leverpostej \
--to=mark.rutland-5wv7dgnigg8@public.gmane.org \
--cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ganapatrao.kulkarni-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \
--cc=gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).