devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Jyri Sarha <jsarha@ti.com>
Cc: Mark Brown <broonie@kernel.org>,
	dri-devel@lists.freedesktop.org, airlied@linux.ie,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	bcousson@baylibre.com, alsa-devel@alsa-project.org,
	tony@atomide.com, liam.r.girdwood@linux.intel.com,
	peter.ujfalusi@ti.com, detheridge@ti.com, t-kristo@ti.com
Subject: Re: [PATCH v3 4/5] ASoC: davinci: HDMI audio build for AM33XX and TDA998x
Date: Thu, 18 Sep 2014 10:25:44 +0200	[thread overview]
Message-ID: <20140918102544.26b28b6b@armhf> (raw)
In-Reply-To: <5419F965.9060209@ti.com>

On Thu, 18 Sep 2014 00:13:09 +0300
Jyri Sarha <jsarha@ti.com> wrote:

> > So, Jean-Francois is also trying to do things with the TDA998x - what's
> > the story with that, is this joined up at all?
> 
> Not really. This basic functionality does not touch tda998x at all on 
> the fly, but just sets i2s configuation in the beginning and bangs the 
> bits trough McASP. But as long as the old platform data for tda998x 
> still works after Jean-Francois' patches I should be safe.

It should. And you may test it.

> The problem with the Jean-Francois' patches is the DT support. The BBB 
> HDMI video is implemented trough tilcdc-slave mechanism without a DT 
> node for the tda encoder, which renders Jean-Francois' approach unusable 
> for BBB.

I used the TDA998x with DT support for a long time with a hack by using
parts of drm_i2c_encoder_init(). Now, I think that this function could
be used as it is just setting no platform_data in info.

> The whole tilcdc slave approach may not be the most elegant way to use 
> the tda driver, but it does not look like it is going to change any time 
> soon.

Right: I proposed a patch for that and it was rejected.

> Best regards,
> Jyri
> 
> ps. I have been thinking on something similar to Jean-Francois' patch 
> for SiI9022 which I have been working on lately. Also I have been 
> wondering if it would be possible to come up with a generic ASoC codec 
> component driver or library that could be used with any HDMI encoder to 
> produce the ASoC codec component. Unfortunately I am in too early stage 
> to produce anything more concrete.

Here are some thoughts about this topic.

The video and audio worlds don't know about each other.
The only solution I found is to let the encoder create the codec as
a child device. Then, the codec knows from which encoder it depends.
This could have been done using Russell's components, but the codec
should have been declared in the DT. This is not useful.

The codec interacts with the encoder in 2 ways:
- it uses the HDMI parameters retrieved by the encoder,
- it gives the audio source type to the encoder.
I used exported functions for that, but, for a generic codec, theses
functions could be given through the codec platform_data.

The codec declares the DAI(s) prior to know the encoder. The DAI table
must be in the codec because of the snd_soc_dai_ops.
For a generic codec, this DAI table could be built dynamically from
information (name, id) also given through the codec platform_data.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-09-18  8:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 20:40 [PATCH v3 0/5] Beaglebone-Black HDMI audio Jyri Sarha
2014-09-16 20:40 ` [PATCH v3 1/5] clk: ti: add "ti,gpio-gate-clock" controlled clock Jyri Sarha
2014-09-19 13:07   ` Tomi Valkeinen
2014-09-19 13:12     ` Nishanth Menon
2014-09-19 13:25       ` Tomi Valkeinen
2014-09-26 23:56         ` Mike Turquette
2014-09-16 20:40 ` [PATCH v3 2/5] drm/tilcdc: Add I2S HDMI audio config for tda998x Jyri Sarha
2014-09-16 20:40 ` [PATCH v3 4/5] ASoC: davinci: HDMI audio build for AM33XX and TDA998x Jyri Sarha
2014-09-17 19:41   ` Mark Brown
2014-09-17 21:13     ` Jyri Sarha
2014-09-18  8:25       ` Jean-Francois Moine [this message]
2014-09-18 18:36         ` Jyri Sarha
     [not found] ` <cover.1410898073.git.jsarha-l0cyMroinI0@public.gmane.org>
2014-09-16 20:40   ` [PATCH v3 3/5] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus Jyri Sarha
2014-09-16 20:40   ` [PATCH v3 5/5] ARM: dts: am335x-boneblack: Add HDMI audio support Jyri Sarha
2014-09-29  6:41     ` Jyri Sarha
2014-09-17  1:06 ` [alsa-devel] [PATCH v3 0/5] Beaglebone-Black HDMI audio Dave Airlie
     [not found]   ` <CAPM=9txRReSdcB5j+0dKmrDNM94zANu-q7ZfWHtP2iA54Dieig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-17  7:51     ` Jyri Sarha
2014-09-19 13:24       ` Tomi Valkeinen
2014-09-19 13:59         ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140918102544.26b28b6b@armhf \
    --to=moinejf@free.fr \
    --cc=airlied@linux.ie \
    --cc=alsa-devel@alsa-project.org \
    --cc=bcousson@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=detheridge@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).