From: Thierry Reding <thierry.reding@gmail.com>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-pwm@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@atmel.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Bo Shen <voice.shen@atmel.com>, Kumar Gala <galak@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Andrew Victor <linux@maxim.org.za>
Subject: Re: [PATCH v5 05/11] drm: add Atmel HLCDC Display Controller support
Date: Tue, 23 Sep 2014 08:32:33 +0200 [thread overview]
Message-ID: <20140923063232.GG30514@ulmo> (raw)
In-Reply-To: <20140922211811.11279ff0@bbrezillon>
[-- Attachment #1.1: Type: text/plain, Size: 1168 bytes --]
On Mon, Sep 22, 2014 at 09:18:11PM +0200, Boris BREZILLON wrote:
> On Mon, 8 Sep 2014 10:43:36 +0200 Boris BREZILLON <boris.brezillon@free-electrons.com> wrote:
[...]
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > new file mode 100644
> > index 0000000..6d0d785
> > --- /dev/null
> > +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > @@ -0,0 +1,13 @@
> > +config DRM_ATMEL_HLCDC
> > + tristate "DRM Support for ATMEL HLCDC Display Controller"
> > + depends on DRM && OF && MFD_ATMEL_HLCDC && COMMON_CLK
>
> I forgot to remove MFD_ATMEL_HLCDC dependency which is now selected...
>
>
> > + select DRM_GEM_CMA_HELPER
> > + select DRM_KMS_HELPER
> > + select DRM_KMS_FB_HELPER
> > + select DRM_KMS_CMA_HELPER
> > + select DRM_PANEL
> > + select MFD_ATMEL_HLCDC
>
> here.
Maybe this was discussed earlier, but can you remind me why this was
done? The changelog says it was to "simplify", but there's been some
recent discussion that select should never be used for symbols that
are user-visible because that can lead to issues.
What were the problems having this as "depends on"?
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-09-23 6:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 8:43 [PATCH v5 00/11] drm: add support for Atmel HLCDC Display Controller Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 01/11] mfd: add atmel-hlcdc driver Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 02/11] mfd: add documentation for atmel-hlcdc DT bindings Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 03/11] pwm: add support for atmel-hlcdc-pwm device Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 05/11] drm: add Atmel HLCDC Display Controller support Boris BREZILLON
2014-09-19 13:10 ` David Herrmann
2014-09-22 9:15 ` Boris BREZILLON
2014-09-22 19:18 ` Boris BREZILLON
2014-09-23 6:32 ` Thierry Reding [this message]
2014-09-23 7:24 ` Boris BREZILLON
2014-09-23 8:42 ` Thierry Reding
2014-09-23 9:55 ` Nicolas Ferre
2014-09-26 21:10 ` Rob Clark
2014-09-27 20:12 ` Boris BREZILLON
2014-09-28 3:52 ` Rob Clark
2014-09-08 8:43 ` [PATCH v5 06/11] drm: add DT bindings documentation for atmel-hlcdc-dc driver Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 07/11] ARM: AT91/dt: split sama5d3 lcd pin definitions to match RGB mode configs Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 08/11] ARM: AT91/dt: add alternative pin muxing for sama5d3 lcd pins Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 09/11] ARM: at91/dt: define the HLCDC node available on sama5d3 SoCs Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 10/11] ARM: at91/dt: add LCD panel description to sama5d3xdm.dtsi Boris BREZILLON
2014-09-08 8:43 ` [PATCH v5 11/11] ARM: at91/dt: enable the LCD panel on sama5d3xek boards Boris BREZILLON
2014-09-09 8:09 ` [PATCH v5 00/11] drm: add support for Atmel HLCDC Display Controller Harivel, Anthony
2014-09-26 0:02 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923063232.GG30514@ulmo \
--to=thierry.reding@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=ludovic.desroches@atmel.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).