From: Beniamino Galvani <b.galvani@gmail.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Carlo Caione <carlo@caione.org>,
Jerry Cao <jerry.cao@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: net: stmmac glue layer for Amlogic Meson SoCs
Date: Tue, 23 Sep 2014 13:15:00 +0200 [thread overview]
Message-ID: <20140923111459.GA4487@gmail.com> (raw)
In-Reply-To: <54211032.6010009@st.com>
On Tue, Sep 23, 2014 at 08:16:18AM +0200, Giuseppe CAVALLARO wrote:
> On 9/20/2014 3:29 PM, Beniamino Galvani wrote:
> >Hi,
> >
> >the Ethernet controller available in Amlogic Meson6 and Meson8 SoCs is
> >a Synopsys DesignWare MAC IP core, already supported by the stmmac
> >driver.
> >
> >These patches add a glue layer to the driver for the platform-specific
> >settings required by the Amlogic variant.
> >
> >This has been tested on a Amlogic S802 device with the initial Meson
> >support submitted by Carlo Caione [1].
>
> patches look fine just a warning with checkpatch as shown below then
>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>
>
> [cavagiu@lxmcdt5 net.git]$ git-format-patch -2
> 0001-net-stmmac-add-Amlogic-Meson-glue-layer.patch
> 0002-net-stmmac-meson-document-device-tree-bindings.patch
> [cavagiu@lxmcdt5 net.git]$ !./
> ./scripts/checkpatch.pl 000*
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #57:
> new file mode 100644
>
> WARNING: DT compatible string vendor "amlogic" appears un-documented
> -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt
> #152: FILE: drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:34:
> + { .compatible = "amlogic,meson6-dwmac", .data = &meson6_dwmac_data},
Hi Giuseppe,
thanks for the review. The amlogic vendor prefix is documented as part
of the initial Meson support in the series reported in the cover
letter.
Beniamino
>
> total: 0 errors, 2 warnings, 0 checks, 108 lines checked
>
> 0001-net-stmmac-add-Amlogic-Meson-glue-layer.patch has style
> problems, please review.
>
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #17:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 25 lines checked
>
> 0002-net-stmmac-meson-document-device-tree-bindings.patch has style
> problems, please review.
>
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> >
> >[1] http://lwn.net/Articles/612000/
> >
> >Beniamino Galvani (2):
> > net: stmmac: add Amlogic Meson glue layer
> > net: stmmac: meson: document device tree bindings
> >
> > .../devicetree/bindings/net/meson-dwmac.txt | 25 ++++++++
> > drivers/net/ethernet/stmicro/stmmac/Kconfig | 10 ++++
> > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
> > drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 67 ++++++++++++++++++++++
> > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 +
> > .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 +
> > 6 files changed, 109 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/meson-dwmac.txt
> > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c
> >
>
next prev parent reply other threads:[~2014-09-23 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 13:29 net: stmmac glue layer for Amlogic Meson SoCs Beniamino Galvani
2014-09-20 13:29 ` [PATCH 1/2] net: stmmac: add Amlogic Meson glue layer Beniamino Galvani
2014-09-20 13:29 ` [PATCH 2/2] net: stmmac: meson: document device tree bindings Beniamino Galvani
[not found] ` <1411219757-9201-1-git-send-email-b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-23 6:16 ` net: stmmac glue layer for Amlogic Meson SoCs Giuseppe CAVALLARO
2014-09-23 11:15 ` Beniamino Galvani [this message]
2014-09-26 4:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923111459.GA4487@gmail.com \
--to=b.galvani@gmail.com \
--cc=carlo@caione.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jerry.cao@amlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).