From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com,
alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller
Date: Tue, 23 Sep 2014 16:41:18 +0200 [thread overview]
Message-ID: <20140923144118.GF18924@kwain> (raw)
In-Reply-To: <3708177.kEGF9Dk44n@wuerfel>
On Tue, Sep 23, 2014 at 04:33:48PM +0200, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 16:01:13 Antoine Tenart wrote:
> >
> > On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote:
> > > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote:
> > > > +Optional properties:
> > > > +- port-id: should be '0','1' or '2'.
> > > > +- phy-addr: MDIO address of the PHY.
> > > > +- local-mac-address: see ethernet.txt file in the same directory.
> > > > +
> > > >
> > >
> > > I believe new bindings should not use "phy-addr" properties, but
> > > instead use a phy-handle property pointing to a phy device instead.
> >
> > That's the MDIO address of the PHY. It's a bit difficult to use a phy
> > device as the driver uses the libphy. And that would break the platform
> > using it.
> >
> > Or maybe you have something in mind?
>
> I don't understand what you mean. Doesn't libphy imply using a phy_device?
> What I meant was that you should be able to just call the standard
> of_phy_connect() and other interfaces to deal with phylib.
>
Yes sure, I read again my answer and... well I should have had a better
look on the matter.
Anyway, as the proposed binding seems to be OK with you, I'll update the
series accordingly.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-23 14:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 12:15 [PATCH v4 0/9] ARM: Berlin: Ethernet support Antoine Tenart
2014-09-23 12:15 ` [PATCH v4 1/9] net: pxa168_eth: clean up Antoine Tenart
2014-09-23 12:15 ` [PATCH v4 2/9] net: pxa168_eth: add device tree support Antoine Tenart
2014-09-23 12:15 ` [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller Antoine Tenart
2014-09-23 12:38 ` Arnd Bergmann
2014-09-23 14:01 ` Antoine Tenart
2014-09-23 14:29 ` Antoine Tenart
2014-09-23 14:37 ` Arnd Bergmann
2014-09-23 15:45 ` Sebastian Hesselbarth
[not found] ` <542195B0.6080706-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-23 16:29 ` Arnd Bergmann
2014-09-23 16:40 ` Sebastian Hesselbarth
2014-09-23 17:02 ` Arnd Bergmann
2014-09-23 17:31 ` Sebastian Hesselbarth
[not found] ` <5421AE7C.30504-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-23 18:18 ` Arnd Bergmann
2014-09-23 14:33 ` Arnd Bergmann
2014-09-23 14:41 ` Antoine Tenart [this message]
2014-09-23 12:15 ` [PATCH v4 4/9] net: pxa168_eth: fix Ethernet flow control status Antoine Tenart
2014-09-23 12:15 ` [PATCH v4 5/9] net: pxa168_eth: set the mac address on the Ethernet controller Antoine Tenart
2014-09-23 12:15 ` [PATCH v4 6/9] net: pxa168_eth: rework the MAC address setup Antoine Tenart
[not found] ` <1411474536-22626-1-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-09-23 12:15 ` [PATCH v4 7/9] net: pxa168_eth: allow Berlin SoCs to use the pxa168_eth driver Antoine Tenart
2014-09-23 12:40 ` Arnd Bergmann
2014-09-23 13:50 ` Antoine Tenart
2014-09-23 12:15 ` [PATCH v4 8/9] ARM: dts: berlin: add the Ethernet node Antoine Tenart
2014-09-23 12:15 ` [PATCH v4 9/9] ARM: dts: berlin: enable the Ethernet port on the BG2Q DMP Antoine Tenart
2014-09-23 12:41 ` [PATCH v4 0/9] ARM: Berlin: Ethernet support Arnd Bergmann
2014-09-23 14:01 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923144118.GF18924@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).