From: Lee Jones <lee.jones@linaro.org>
To: Johannes Pointner <johannes.pointner@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
AnilKumar Ch <anilkumar@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: tps65217: add compatible string for subdevices
Date: Wed, 24 Sep 2014 12:06:02 +0100 [thread overview]
Message-ID: <20140924110602.GI19999@lee--X1> (raw)
In-Reply-To: <5439652.jHp5aCCfrZ@lenovobook>
On Mon, 22 Sep 2014, Johannes Pointner wrote:
> The TPS65217 is missing of_compatible string in the mfd_cell for its
> subdevices. This compatible string is necessary to use functions like
> of_find_backlight_by_node in backlight.c.
>
> Signed-off-by: Johannes Pointner <johannes.pointner@br-automation.com>
> ---
> Documentation/devicetree/bindings/regulator/tps65217.txt | 5 ++++-
> .../devicetree/bindings/video/backlight/tps65217-backlight.txt | 6 +++---
> drivers/mfd/tps65217.c | 2 ++
> 3 files changed, 9 insertions(+), 4 deletions(-)
[...]
> diff --git a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> index 5fb9279..c3fb649 100644
> --- a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> +++ b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> @@ -7,18 +7,18 @@ Required properties:
> - compatible: "ti,tps65217"
> - reg: I2C slave address
> - backlight: node for specifying WLED1 and WLED2 lines in TPS65217
> +- compatible: "ti,tps65217-bl"
This is now confusing. Please make it clear that this part of the
documentation is now referencing the sub-node.
> - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
> - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
> - default-brightness: valid values: 0-100
>
> -Each regulator is defined using the standard binding for regulators.
> -
> Example:
>
> tps: tps@24 {
> reg = <0x24>;
> compatible = "ti,tps65217";
> - backlight {
> + tps_bl: backlight {
> + compatible = "ti,tps65217-bl";
> isel = <1>; /* 1 - ISET1, 2 ISET2 */
> fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
> default-brightness = <50>;
> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
This shouldn't be in this patch.
Please adhere to: Documentation/devicetree/bindings/submitting-patches.txt
> index 3cc4c70..77708f9 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -33,9 +33,11 @@
> static const struct mfd_cell tps65217s[] = {
> {
> .name = "tps65217-pmic",
> + .of_compatible = "ti,tps65217-pmic",
> },
> {
> .name = "tps65217-bl",
> + .of_compatible = "ti,tps65217-bl",
> },
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-09-24 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 18:18 [PATCH] mfd: tps65217: add compatible string for subdevices Johannes Pointner
2014-09-24 11:06 ` Lee Jones [this message]
2014-09-24 11:49 ` Johannes Pointner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924110602.GI19999@lee--X1 \
--to=lee.jones@linaro.org \
--cc=anilkumar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=johannes.pointner@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox