From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH 3/7] clk: sunxi: unify sun6i AHB1 clock with proper PLL6 pre-divider Date: Thu, 25 Sep 2014 16:03:40 -0700 Message-ID: <20140925230340.19023.22674@quantum> References: <1410000448-9999-1-git-send-email-wens@csie.org> <1410000448-9999-4-git-send-email-wens@csie.org> <20140911210211.GM31276@lukather> <20140913102603.GZ31276@lukather> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140913102603.GZ31276@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard , Chen-Yu Tsai Cc: Emilio Lopez , Vinod Koul , Dan Williams , Grant Likely , Rob Herring , linux-arm-kernel , linux-sunxi , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree List-Id: devicetree@vger.kernel.org Quoting Maxime Ripard (2014-09-13 03:26:03) > On Fri, Sep 12, 2014 at 11:16:26AM +0800, Chen-Yu Tsai wrote: > > Hi, > > > > On Fri, Sep 12, 2014 at 5:02 AM, Maxime Ripard > > wrote: > > > Hi, > > > > > > On Sat, Sep 06, 2014 at 06:47:24PM +0800, Chen-Yu Tsai wrote: > > >> This patch unifies the sun6i AHB1 clock, originally supported > > >> with separate mux and divider clks. It also adds support for > > >> the pre-divider on the PLL6 input, thus allowing the clock to > > >> be muxed to PLL6 with proper clock rate calculation. > > >> > > >> Signed-off-by: Chen-Yu Tsai > > > > > > It looks fine, but I'd rather see this in a separate file, especially > > > since we don't seem to have any order dependency. > > > > Sorry, just to be clear, separate file under clk/sunxi? > > Yes > > > This cannot be in a separate file, as it shares a spinlock with apb1 > > divider. They share the same register. > > > > We could move apb1 out though. But i would prefer to do that when > > we split out all the clocks into individual OF_CLK_DECLAREs. > > Ah right, my bad :) > > My plan on the long term is to kill clk-sunxi as a place where all the > clocks are defined, and only leave the "policy" there, for example the > clock protection code (even if that should probably be removed too, > together with clkdev), the various rates / parenting enforcements, > etc. Interesting! Where are you planning to store the clock data? Regards, Mike > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com