From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH v3 00/12] clk: sunxi: Improve MMC clocks support Date: Fri, 26 Sep 2014 10:52:44 -0700 Message-ID: <20140926175244.19023.49065@quantum> References: <1410466706-27386-1-git-send-email-maxime.ripard@free-electrons.com> <20140922113133.GF15315@lukather> <20140926004218.19023.88602@quantum> <20140926065507.GO15315@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140926065507.GO15315@lukather> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maxime Ripard Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, Emilio Lopez , linux-mmc@vger.kernel.org, chris@printf.net, Hans de Goede , wens@csie.org, david.lanzendoerfer@o2s.ch, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Quoting Maxime Ripard (2014-09-25 23:55:07) > Hi Mike, > > On Thu, Sep 25, 2014 at 05:42:18PM -0700, Mike Turquette wrote: > > Quoting Maxime Ripard (2014-09-22 04:31:33) > > > Mike, > > > > > > On Thu, Sep 11, 2014 at 10:18:14PM +0200, Maxime Ripard wrote: > > > > Hi everyone, > > > > > > > > Here is an attempt at improving the MMC clock support in the Allwinner > > > > SoCs. > > > > > > > > Until now, the MMC clocks were having a custom phase function that was > > > > directly setting an obscure value in the right register, because we > > > > were not really having any idea of what these values were. > > > > > > > > Now that we have more informations, we can introduce a common function > > > > call to get and set the phase of a particular clock, and use this in > > > > both our provider and our client. > > > > > > It would be great that we have that custom phase API out of the kernel > > > for 3.18, and you were one of the greatest supporters to that idea, > > > could we please have your view on this? > > > > Patches all look good to me. Did you want the whole series to go through > > the clk tree? > > I guess it would be where it most make sense yes. > > > If so we'll need an Ack for the MMC patch and for the ARM DTS > > patches as well. > > We already have an Ack from Ulf on the MMC patch, and I'm the > maintainer of the DTS involved, so we should be ok :) Oops, I didn't notice Ulf's Ack. Will either your or Emilio be sending a pull request for the sunxi clock changes? Regards, Mike > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com