[PATCH] serial: mxs-auart: add sysrq support

[PATCH] serial: mxs-auart: add sysrq support

[Janusz Uzycki]

This is rather obvious patch now.
The patch is resent as cleaned independent from the patchset:
"Re: [PATCH 1/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals (v2.2c)"

Who could apply the patch?

best regards
Janusz

[PATCH] serial: mxs-auart: add sysrq support

[Janusz Uzycki]

When using mxs-auart based console, sometime we need the sysrq function
to help debugging kernel. The sysrq code is basically there,
this patch just simply enable it.

Signed-off-by: Janusz Uzycki <j.uzycki@elproma.com.pl>
---
 drivers/tty/serial/mxs-auart.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 9381732..4c998a3 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -14,6 +14,10 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
+#if defined(CONFIG_SERIAL_MXS_AUART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
-- 
1.7.11.3

Re: [PATCH] serial: mxs-auart: add sysrq support

[Greg Kroah-Hartman]

On Fri, Sep 26, 2014 at 04:08:05PM +0200, Janusz Uzycki wrote:
> This is rather obvious patch now.
> The patch is resent as cleaned independent from the patchset:
> "Re: [PATCH 1/4] serial: mxs-auart: use mctrl_gpio helpers for handling modem signals (v2.2c)"
> 
> Who could apply the patch?

I have so many patches from you for this driver in my inbox, yet almost
no idea which to apply.  Please always properly label which series
obsoletes previous ones, and what order the patches need to be applied
in (your latest patches lack this entirely.)

So I'm deleting all of these now, please resend the latest versions you
have, with properly versioning and order information.

thanks,

greg k-h

Re: [PATCH] serial: mxs-auart: add sysrq support

[Janusz Uzycki]

> So I'm deleting all of these now, please resend the latest
> versions you have, with properly versioning
> and order information.

Sure. If you don't want to comment dirty patches
I will not send you them.
I can send you only the final version, commented before.

On the moment this patch is ready to apply.

[PATCH RESEND] serial: mxs-auart: add sysrq support
The patch is resent to apply.

Re: [PATCH] serial: mxs-auart: add sysrq support

[Fabio Estevam]

Janusz,

On Mon, Sep 29, 2014 at 11:11 AM, Janusz Uzycki <j.uzycki@elproma.com.pl> wrote:
>> So I'm deleting all of these now, please resend the latest
>> versions you have, with properly versioning
>> and order information.
>
> Sure. If you don't want to comment dirty patches
> I will not send you them.
> I can send you only the final version, commented before.
>
> On the moment this patch is ready to apply.
>
> [PATCH RESEND] serial: mxs-auart: add sysrq support
> The patch is resent to apply.

What Greg is asking you to do is to provide a proper version
annotation in your patches.

For example: [PATCH v2] serial: mxs-auart: add ...

Then if you need to submit it again you should do:

[PATCH v3] serial: mxs-auart: add ...

Also, always explain below the --- line what changed from one version to another

Re: [PATCH] serial: mxs-auart: add sysrq support

[Janusz Użycki]

Hi,

W dniu 2014-10-04 18:19, Fabio Estevam pisze:
> Janusz,
>
> On Mon, Sep 29, 2014 at 11:11 AM, Janusz Uzycki <j.uzycki@elproma.com.pl> wrote:
>>> So I'm deleting all of these now, please resend the latest
>>> versions you have, with properly versioning
>>> and order information.
>> Sure. If you don't want to comment dirty patches
>> I will not send you them.
>> I can send you only the final version, commented before.
>>
>> On the moment this patch is ready to apply.
>>
>> [PATCH RESEND] serial: mxs-auart: add sysrq support
>> The patch is resent to apply.
> What Greg is asking you to do is to provide a proper version
> annotation in your patches.
>
> For example: [PATCH v2] serial: mxs-auart: add ...
>
> Then if you need to submit it again you should do:
>
> [PATCH v3] serial: mxs-auart: add ...

I will resend the rest of patches (as v4) this week.
This simple patch is independent from the previous patchset so
I decided to resubmit it alone ([PATCH RESEND] header used)
to apply.

I rather shouldn't resend the patch again I guess.
I sent the same initial version of the patch twice
after Greg's email so I did mess enough I think.

> Also, always explain below the --- line what changed from one version to another
I thought composing cover letter is the only solution for resent patch 
or series.
As I understood this way is appropriate for single patch only (not patch 
set).
"Below" - it means between the line and diffstat?
Should I add new/second '---' line before diffstat?

best regards
Janusz

Re: [PATCH] serial: mxs-auart: add sysrq support

[Fabio Estevam]

On Mon, Oct 6, 2014 at 8:34 AM, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
> Hi,
>
> W dniu 2014-10-04 18:19, Fabio Estevam pisze:
>
>> Janusz,
>>
>> On Mon, Sep 29, 2014 at 11:11 AM, Janusz Uzycki <j.uzycki@elproma.com.pl>
>> wrote:
>>>>
>>>> So I'm deleting all of these now, please resend the latest
>>>> versions you have, with properly versioning
>>>> and order information.
>>>
>>> Sure. If you don't want to comment dirty patches
>>> I will not send you them.
>>> I can send you only the final version, commented before.
>>>
>>> On the moment this patch is ready to apply.
>>>
>>> [PATCH RESEND] serial: mxs-auart: add sysrq support
>>> The patch is resent to apply.
>>
>> What Greg is asking you to do is to provide a proper version
>> annotation in your patches.
>>
>> For example: [PATCH v2] serial: mxs-auart: add ...
>>
>> Then if you need to submit it again you should do:
>>
>> [PATCH v3] serial: mxs-auart: add ...
>
>
> I will resend the rest of patches (as v4) this week.
> This simple patch is independent from the previous patchset so
> I decided to resubmit it alone ([PATCH RESEND] header used)
> to apply.
>
> I rather shouldn't resend the patch again I guess.
> I sent the same initial version of the patch twice
> after Greg's email so I did mess enough I think.
>
>> Also, always explain below the --- line what changed from one version to
>> another
>
> I thought composing cover letter is the only solution for resent patch or
> series.
> As I understood this way is appropriate for single patch only (not patch
> set).
> "Below" - it means between the line and diffstat?
> Should I add new/second '---' line before diffstat?

Just do something like:

When using mxs-auart based console, sometime we need the sysrq function
to help debugging kernel. The sysrq code is basically there,
this patch just simply enable it.

Signed-off-by: Janusz Uzycki <j.uzycki@elproma.com.pl>
---
Changes since v3:
- bla bla bla
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] serial: mxs-auart: add sysrq support

[Janusz Uzycki]

> So I'm deleting all of these now, please resend the latest
> versions you have, with properly versioning
> and order information.
Sure. I've just learnt about RFC header.

[PATCH RESEND] serial: mxs-auart: add sysrq support
It is extracted from my previous patchset
as independent from others.
The patch is resent as ready to apply.

I resend it again because last time
in conver letter I swapped subject with
in-reply-to and the patch could be omited.

Janusz Uzycki (1):
  serial: mxs-auart: add sysrq support

 drivers/tty/serial/mxs-auart.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
1.7.11.3

[PATCH RESEND] serial: mxs-auart: add sysrq support

[Janusz Uzycki]

When using mxs-auart based console, sometime we need the sysrq function
to help debugging kernel. The sysrq code is basically there,
this patch just simply enable it.

Signed-off-by: Janusz Uzycki <j.uzycki-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
---
 drivers/tty/serial/mxs-auart.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index eafce41..e838e84 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -14,6 +14,10 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
+#if defined(CONFIG_SERIAL_MXS_AUART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/init.h>
-- 
1.7.11.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html