Re: [PATCH v2 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

[Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>]

On Sat, Sep 27, 2014 at 05:03:00PM +0100, Darshana Padmadas wrote:
>    On Friday, September 26, 2014 7:20:50 PM UTC+5:30, Mark Rutland wrote:
> 
>      Hi,
> 
>      On Fri, Sep 26, 2014 at 01:24:52PM +0100, Darshana Padmadas wrote:
>      > This patch adds the correct vendor-prefix listed in
>      Documentation/devicetree/bindings/vendor-prefixes.txt
>      > with the device name to compatible property.
>      >
>      > Signed-off-by: Darshana Padmadas <[1]darshana...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>      > ---
>      >  arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
>      >  1 file changed, 1 insertion(+), 1 deletion(-)
>      >
>      > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi
>      b/arch/arm/boot/dts/tegra30-cardhu.dtsi
>      > index 2063795..491fed6 100644
>      > --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
>      > +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
>      > @@ -187,7 +187,7 @@
>      >  
>      >                  /* ALS and Proximity sensor */
>      >                  isl29028@44 {
>      > -                        compatible = "isil,isl29028";
>      > +                        compatible = "isl,isl29028", "isil,isl29028";
> 
>      Please either drop the old string, or don't add the new string.
> 
>      For compatibility with old DTBs, the kernel must continue to support the
>      old string. So the old string will alone will work -- it's not necessary
>      to add the new one to DTs just because the kernel now supports it.
> 
>      However, this DTB need not work with older kernels, so you could simply
>      replace the string with the new one if your aim is to remove instances
>      of "isil" to ensure consistency going forwards. If so, please mention
>      that in the commit message.
> 
>    So I simply replace isil with isl for the newer kernels? 

For the dts(i) files, that should be fine. You will need to Cc the Tegra
maintainers to verify if they're ok with that.

As an aside, your email came through as HTML, which some lists will
reject. Please ensure your mail client sends plain text.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html