From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v8 2/3] dt-bindings: video: Add for rockchip display subsytem Date: Tue, 30 Sep 2014 10:10:20 +0200 Message-ID: <20140930081020.GE24667@phenom.ffwll.local> References: <1412057386-19375-1-git-send-email-mark.yao@rock-chips.com> <1412057659-19483-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1412057659-19483-1-git-send-email-mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Yao Cc: heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, Boris BREZILLON , David Airlie , Rob Clark , Daniel Vetter , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Grant Likely , Greg Kroah-Hartman , John Stultz , Rom Lemarchand , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dbehr-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org, kfx@rock-chips.c List-Id: devicetree@vger.kernel.org On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: > From: Mark yao > > This add a display subsystem comprise the all display interface nodes. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark Just a quick clarification: My ack was only about the drm driver itself, I try really hard to stay away from DT insanity ;-) So please drop my ack from these two patches. Aside: DT patches need to go through a special process and you must cc dt maintainers and mailing lists. Your patch seems to lack this, which afaiui is a blocker for merging the driver. Thanks, Daniel > --- > Changes in v2: > - add DRM master device node to list all display nodes that comprise > the graphics subsystem. > > Changes in v3: None > > Changes in v4: None > > Changes in v5: None > > Changes in v6: None > > Changes in v7: None > > Changes in v8: None > > .../devicetree/bindings/video/rockchip-drm.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/rockchip-drm.txt > > diff --git a/Documentation/devicetree/bindings/video/rockchip-drm.txt b/Documentation/devicetree/bindings/video/rockchip-drm.txt > new file mode 100644 > index 0000000..7fff582 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/rockchip-drm.txt > @@ -0,0 +1,19 @@ > +Rockchip DRM master device > +================================ > + > +The Rockchip DRM master device is a virtual device needed to list all > +vop devices or other display interface nodes that comprise the > +graphics subsystem. > + > +Required properties: > +- compatible: Should be "rockchip,display-subsystem" > +- ports: Should contain a list of phandles pointing to display interface port > + of vop devices. vop definitions as defined in > + Documentation/devicetree/bindings/video/rockchip-vop.txt > + > +example: > + > +display-subsystem { > + compatible = "rockchip,display-subsystem"; > + ports = <&vopl_out>, <&vopb_out>; > +}; > -- > 1.7.9.5 > > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch