From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [RFC 3/7] mfd: devicetree: bindings: Add Qualcomm SMD based RPM DT binding Date: Tue, 30 Sep 2014 07:37:41 -0700 Message-ID: <20140930143740.GK28481@sonymobile.com> References: <1412037291-16880-1-git-send-email-bjorn.andersson@sonymobile.com> <1412037291-16880-4-git-send-email-bjorn.andersson@sonymobile.com> <85C5C172-D309-41B4-B511-7820BAFDA017@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <85C5C172-D309-41B4-B511-7820BAFDA017@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Kumar Gala Cc: Andy Gross , Arnd Bergmann , Grant Likely , Ian Campbell , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , Rob Herring , Samuel Ortiz , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm , "linux-kernel@vger.kernel.org" , Jeffrey Hugo List-Id: devicetree@vger.kernel.org On Tue 30 Sep 06:46 PDT 2014, Kumar Gala wrote: >=20 > On Sep 29, 2014, at 7:34 PM, Bjorn Andersson wrote: >=20 > > diff --git a/Documentation/devicetree/bindings/mfd/qcom-rpm-smd.txt= b/Documentation/devicetree/bindings/mfd/qcom-rpm-smd.txt > > new file mode 100644 > > index 0000000..a846101 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/qcom-rpm-smd.txt > > @@ -0,0 +1,122 @@ > > +Qualcomm Resource Power Manager (RPM) over SMD > > + > > +This driver is used to interface with the Resource Power Manager (= RPM) found in > > +various Qualcomm platforms. The RPM allows each component in the s= ystem to vote > > +for state of the system resources, such as clocks, regulators and = bus > > +frequencies. > > + > > +- compatible: > > + Usage: required > > + Value type: > > + Definition: must be one of: > > + "qcom,rpm-msm8974=94 >=20 > Why not =93qcom,rpm-smd=94. I=92d like to get Jeff H=92s input on ho= w > what we do here for compat and distinguish the A-family RPM support v= s > B-family/RPM-SMD support. >=20 I don't see anything indicating changes in the actual communication, bu= t as this also encodes what resources are exposed we have to keep this speci= fic. I'm not sure what you mean with distinguish the A and B family, they ar= e completely different and there are no overlap in compatibles or impleme= ntation. The overlap is in how children are communicating with the rpm, but this= is an implementation detail - and noted in that patch as a future improvement= =2E I forgot to add Jeff, but did send him a separate email asking for his = input on all this. > > + > > +- qcom,smd-channels: > > + Usage: required > > + Value type: > > + Definition: Shared Memory Channel used for communication with the= RPM > > + >=20 > This needs more details. >=20 Not sure what more to add here. It should contain the name of the chann= el used for communication with the rpm. For all current platforms this would be "rpm_requests". > > +- #address-cells: > > + Usage: required > > + Value type: > > + Definition: must be 1 > > + > > +- #size-cells: > > + Usage: required > > + Value type: > > + Definition: must be 0 > > + > > +=3D SUBDEVICES >=20 > As I mentioned for the the RPM binding on a-family, we should split o= ut the > devices into their own binding specs. >=20 Please actually read https://lkml.org/lkml/2014/3/10/567, it's now the = third time I send you that link. If you don't like it then ask Rob to revise = his statement. =46or me it makes sense to consolidate the RPM binding in one document = rather than spreading it out in 10 different documents with some implicit dependencies. Regards, Bjorn