From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 4/7] ARM: dts: sun9i: Add A80 Optimus Board support Date: Wed, 1 Oct 2014 12:03:41 +0200 Message-ID: <20141001100341.GJ6884@lukather> References: <1411570141-29960-1-git-send-email-wens@csie.org> <1411570141-29960-5-git-send-email-wens@csie.org> <20140925133427.GI15315@lukather> <20140929095344.GE4388@lukather> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3D7yMlnunRPwJqC7" Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chen-Yu Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel , devicetree , linux-kernel , Shuge , Meng Zhang , ctl , Gregory CLEMENT List-Id: devicetree@vger.kernel.org --3D7yMlnunRPwJqC7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 29, 2014 at 06:04:50PM +0800, Chen-Yu Tsai wrote: > On Mon, Sep 29, 2014 at 5:53 PM, Maxime Ripard > wrote: > > On Sat, Sep 27, 2014 at 09:10:48PM +0800, Chen-Yu Tsai wrote: > >> On Thu, Sep 25, 2014 at 9:34 PM, Maxime Ripard > >> wrote: > >> > On Wed, Sep 24, 2014 at 10:48:58PM +0800, Chen-Yu Tsai wrote: > >> >> The A80 Optimus Board is was launched with the Allwinner A80 SoC. > >> >> It was jointly developed by Allwinner and Merrii. > >> >> > >> >> This board has a UART port, a JTAG connector, USB host ports, a USB > >> >> 3.0 OTG connector, an HDMI output, a micro SD slot, 8G NAND flash, > >> >> 4G DRAM, a camera sensor interface, a WiFi/BT combo chip, a headpho= ne > >> >> jack, IR receiver, and additional GPIO headers. > >> >> > >> >> This patch adds only basic support. > >> >> > >> >> Signed-off-by: Chen-Yu Tsai > >> >> --- > >> >> arch/arm/boot/dts/Makefile | 2 + > >> >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 66 +++++++++++++++++++++= ++++++++++++ > >> >> 2 files changed, 68 insertions(+) > >> >> create mode 100644 arch/arm/boot/dts/sun9i-a80-optimus.dts > >> >> > >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > >> >> index 2f42b18..098f319 100644 > >> >> --- a/arch/arm/boot/dts/Makefile > >> >> +++ b/arch/arm/boot/dts/Makefile > >> >> @@ -424,6 +424,8 @@ dtb-$(CONFIG_MACH_SUN7I) +=3D \ > >> >> sun7i-a20-pcduino3.dtb > >> >> dtb-$(CONFIG_MACH_SUN8I) +=3D \ > >> >> sun8i-a23-ippo-q8h-v5.dtb > >> >> +dtb-$(CONFIG_MACH_SUN9I) +=3D \ > >> >> + sun9i-a80-optimus.dtb > >> >> dtb-$(CONFIG_ARCH_TEGRA) +=3D tegra20-harmony.dtb \ > >> >> tegra20-iris-512.dtb \ > >> >> tegra20-medcom-wide.dtb \ > >> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boo= t/dts/sun9i-a80-optimus.dts > >> >> new file mode 100644 > >> >> index 0000000..f83abab > >> >> --- /dev/null > >> >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> >> @@ -0,0 +1,66 @@ > >> >> +/* > >> >> + * Copyright 2014 Chen-Yu Tsai > >> >> + * > >> >> + * Chen-Yu Tsai > >> >> + * > >> >> + * This file is dual-licensed: you can use it either under the ter= ms > >> >> + * of the GPL or the X11 license, at your option. Note that this d= ual > >> >> + * licensing only applies to this file, and not this project as a > >> >> + * whole. > >> >> + * > >> >> + * a) This library is free software; you can redistribute it and/= or > >> >> + * modify it under the terms of the GNU General Public License= as > >> >> + * published by the Free Software Foundation; either version 2= of the > >> >> + * License, or (at your option) any later version. > >> >> + * > >> >> + * This library is distributed in the hope that it will be use= ful, > >> >> + * but WITHOUT ANY WARRANTY; without even the implied warranty= of > >> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See t= he > >> >> + * GNU General Public License for more details. > >> >> + * > >> >> + * You should have received a copy of the GNU General Public > >> >> + * License along with this library; if not, write to the Free > >> >> + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Bos= ton, > >> >> + * MA 02110-1301 USA > >> >> + * > >> >> + * Or, alternatively, > >> >> + * > >> >> + * b) Permission is hereby granted, free of charge, to any person > >> >> + * obtaining a copy of this software and associated documentat= ion > >> >> + * files (the "Software"), to deal in the Software without > >> >> + * restriction, including without limitation the rights to use, > >> >> + * copy, modify, merge, publish, distribute, sublicense, and/or > >> >> + * sell copies of the Software, and to permit persons to whom = the > >> >> + * Software is furnished to do so, subject to the following > >> >> + * conditions: > >> >> + * > >> >> + * The above copyright notice and this permission notice shall= be > >> >> + * included in all copies or substantial portions of the Softw= are. > >> >> + * > >> >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY K= IND, > >> >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRAN= TIES > >> >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > >> >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > >> >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > >> >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > >> >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE = OR > >> >> + * OTHER DEALINGS IN THE SOFTWARE. > >> >> + */ > >> >> + > >> >> +/dts-v1/; > >> >> +/include/ "sun9i-a80.dtsi" > >> >> + > >> >> +/ { > >> >> + model =3D "Merrii A80 Optimus Board"; > >> >> + compatible =3D "merrii,a80-optimus", "allwinner,sun9i-a80"; > >> >> + > >> >> + chosen { > >> >> + bootargs =3D "earlyprintk console=3DttyS0,115200"; > >> >> + }; > >> > > >> > Since you changed the memory node in the DTSI, you should probably a= dd > >> > one here too, don't you? > >> > >> I thought we left fixing that to the bootloader? > >> I don't see any memory nodes in our other DTS. > > > > Yes, but does the A80 bootloader supports DT and actually fixes it? If > > not, then you'll still have to have a memory node, just like on the > > A31 (and presumably on the A23). >=20 > Not at the moment no. But last I checked none of our board dts files > have separate memory nodes. We only have them in the dtsi, with the > largest supported ram size as its value. Also the bootloader > (u-boot that is) can pass the memory size via atags I think. Only if CONFIG_ARM_ATAG_DTB_COMPAT is set. > At least I'm only getting 512MB RAM on my Optimus, due to u-boot > incorrectly assuming I only have as much. But that's another problem. :( And does it initialize the rest of the memory? > Would this be a problem when using Android fastboot from the stock > u-boot? IIRC, fastboot passes ATAGS anyway, so as long as you have the configuration option mentionned above, you should be safe. --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --3D7yMlnunRPwJqC7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUK9F9AAoJEBx+YmzsjxAgClAQAL4K6fR1UtwVNMlovKcb/YAO qzSfLVJa65grpyTX9EVlhWNEp0QmJxH9m3+PlMMp3+dnKLBUJOEWIPCFu0kvGAfQ iea2+wODdpOHUCzNRm2p8WDLas/mts9kgomyDwcQLSj6RqRWDvaVEFf4qb1QlN9v HSMNOJDX8ItK4TXl0tuqk/6L+CTm9CW6VedzwTlannZwUKmkh6kzTPjbGKFzd6Bg p91mSH1Z8FymzfGNjDo8We4z3IjPV0kr2W4s/pqUHxQY3BvATYbtr+fe3W5G7VR3 RdgwMfAim6HjUCM/nPx2zeIWAwDM5TdfnVDCwVaKJPNeQp9oOvs/hPwAmKf7JhEU Ru15wsNsUvrmsJobqNaYRKHLLWvLFWWO6j5N26ezR48cUJJGoqLWkA84+6P0EWXc 7SWBz6MJkyfShfMnxd/C8Km6DZWBYExn6XNpvQcMANHO59aEDAigVSmmLFmWf3IH A4AHi+Uh3KrUiSJfrL5PG1PJ3zmynftjl8BYpEyddOeT6b/O1ZYOzDnXgWjb38KJ Hu02cmT5bXyUGiutbNFVPEFqqvBvWnxJ6y46+jgTRElgiYpXkHSVOExDxOy8jXqJ 8TrueUigqRnb0oNTb/1w7MHVvzplsb57T5Y2qfm8nXFart+nk43MMl2wo4sh9l38 Jyry/njEaRhNRKyBreur =IlbG -----END PGP SIGNATURE----- --3D7yMlnunRPwJqC7-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html