From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 2/4] ARM: qcom: add description of KPSS WDT for IPQ8064 Date: Wed, 1 Oct 2014 10:28:55 -0700 Message-ID: <20141001172855.GL10233@codeaurora.org> References: <50c0ec1514173ce07641a95839e939dcda41b110.1412182773.git.joshc@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <50c0ec1514173ce07641a95839e939dcda41b110.1412182773.git.joshc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Josh Cartwright Cc: Kumar Gala , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/01, Josh Cartwright wrote: > @@ -96,6 +104,13 @@ > cpu-offset = <0x80000>; > }; > > + watchdog@208a038 { > + compatible = "qcom,kpss-wdt-ipq8064"; > + reg = <0x0208a038 0x40>; Not being aligned to 4k or 1k raises red flags. The watchdog is part of the timer block (on this chip it's "qcom,kpss-timer"). We should add qcom,kpss-wdt to the compatible list in the timer binding and extend that binding to have clocks and timeout-sec (watchdog-timeout-sec?). This would follow DT best practices of having one node per device. We could also add the interrupts too, even if they're not used by the driver right now. > + clocks = <&sleep_clk>; > + timeout-sec = <10>; > + }; > + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html