From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Caione Subject: Re: [PATCH 1/6] ARM: meson: add meson8 machine definition Date: Thu, 2 Oct 2014 20:29:57 +0200 Message-ID: <20141002182957.GA15355@nuc> References: <1412198986-26534-1-git-send-email-b.galvani@gmail.com> <1412198986-26534-2-git-send-email-b.galvani@gmail.com> <11073411.IcmTkIICYA@wuerfel> <20141002170519.GA29052@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20141002170519.GA29052@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Beniamino Galvani Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Victor Wan , Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Rob Herring , Kumar Gala , Jerry Cao List-Id: devicetree@vger.kernel.org On gio, ott 02, 2014 at 07:05:19 +0200, Beniamino Galvani wrote: > On Thu, Oct 02, 2014 at 11:24:54AM +0200, Arnd Bergmann wrote: > > On Wednesday 01 October 2014 23:29:41 Beniamino Galvani wrote: > > > > > > +static const char * const m8_common_board_compat[] = { > > > + "amlogic,meson8", > > > + NULL, > > > +}; > > > + > > > DT_MACHINE_START(AML8726_MX, "Amlogic Meson6 platform") > > > .dt_compat = m6_common_board_compat, > > > MACHINE_END > > > > > > +DT_MACHINE_START(MESON8, "Amlogic Meson8 platform") > > > + .dt_compat = m8_common_board_compat, > > > +MACHINE_END > > > > > > > I'd just add the meson8 string to the m6_common_board_compat list and > > rename it. > > From what I've seen so far the two families are very similar and share > most of the IP cores, so a unique DT machine is a good idea. > > Does the MACH_MESON8 Kconfig symbol still make sense or can I drop it > and rename MACH_MESON6 to MACH_MESON? I would still leave two different MACH_ for meson6 and meson8 since the two architectures aren't _so_ similar. thanks, -- Carlo Caione