devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Iyappan Subramanian <isubramanian@apm.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"patches@apm.com" <patches@apm.com>,
	"kchudgar@apm.com" <kchudgar@apm.com>
Subject: Re: [PATCH v2 3/6] dtb: Add 10GbE node to APM X-Gene SoC device tree
Date: Fri, 3 Oct 2014 13:49:56 +0100	[thread overview]
Message-ID: <20141003124956.GI26643@leverpostej> (raw)
In-Reply-To: <1412294568-26747-4-git-send-email-isubramanian@apm.com>

Hi,

[...]

> +		xgenet: ethernet@1f610000 {
> +			compatible = "apm,xgene-enet";
> +			status = "disabled";
> +			reg = <0x0 0x1f610000 0x0 0xd100>,
> +			      <0x0 0x1f600000 0x0 0X400>,
> +			      <0x0 0x18000000 0x0 0X200>;
> +			reg-names = "enet_csr", "ring_csr", "ring_cmd";
> +			interrupts = <0x0 0x60 0x4>;
> +			dma-coherent;
> +			clocks = <&xge0clk 0>;
> +			local-mac-address = [00 01 73 00 00 04];

Apolgoies, I'd missed your reply on this last time. Please use
all-zeroes for the mac address, and have a comment that this will be
overwritten by the bootloader.

Thanks,
Mark.

  reply	other threads:[~2014-10-03 12:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03  0:02 [PATCH v2 0/6] Add 10GbE support to APM X-Gene SoC ethernet driver Iyappan Subramanian
2014-10-03  0:02 ` [PATCH v2 1/6] MAINTAINERS: Update APM X-Gene section Iyappan Subramanian
     [not found] ` <1412294568-26747-1-git-send-email-isubramanian-qTEPVZfXA3Y@public.gmane.org>
2014-10-03  0:02   ` [PATCH v2 2/6] Documentation: dts: Update section header for APM X-Gene Iyappan Subramanian
2014-10-03  0:02 ` [PATCH v2 3/6] dtb: Add 10GbE node to APM X-Gene SoC device tree Iyappan Subramanian
2014-10-03 12:49   ` Mark Rutland [this message]
2014-10-03  0:02 ` [PATCH v2 4/6] drivers: net: xgene: Preparing for adding 10GbE support Iyappan Subramanian
2014-10-03  0:02 ` [PATCH v2 5/6] drivers: net: xgene: Add " Iyappan Subramanian
2014-10-03  0:02 ` [PATCH v2 6/6] drivers: net: xgene: Add 10GbE ethtool support Iyappan Subramanian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141003124956.GI26643@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=isubramanian@apm.com \
    --cc=kchudgar@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=patches@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).