From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation Date: Fri, 3 Oct 2014 14:05:59 +0100 Message-ID: <20141003130559.GJ26643@leverpostej> References: <1412275071-6417-1-git-send-email-atull@opensource.altera.com> <1412275071-6417-2-git-send-email-atull@opensource.altera.com> <20141003122736.GH26643@leverpostej> <542E9E9B.4090307@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <542E9E9B.4090307-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: "atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org" , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "jdelvare-l3A5Bk7waGM@public.gmane.org" , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Pawel Moll , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org" , "yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, Oct 03, 2014 at 02:03:23PM +0100, Guenter Roeck wrote: > On 10/03/2014 05:27 AM, Mark Rutland wrote: > > On Thu, Oct 02, 2014 at 07:37:48PM +0100, atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote: > >> From: Alan Tull > >> > >> Add device tree bindings documentation for ltc2978. > >> > >> Signed-off-by: Alan Tull > >> --- > >> v2: clean whitespace > >> --- > >> .../devicetree/bindings/hwmon/ltc2978.txt | 41 ++++++++++++++++++++ > >> 1 file changed, 41 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt > >> > >> diff --git a/Documentation/devicetree/bindings/hwmon/ltc2978.txt b/Documentation/devicetree/bindings/hwmon/ltc2978.txt > >> new file mode 100644 > >> index 0000000..b2d9c4d > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/hwmon/ltc2978.txt > >> @@ -0,0 +1,41 @@ > >> +ltc2978 > >> + > >> +Required properties: > >> + - compatible: one of: ltc2974, ltc2977, ltc2978, ltc3880, ltc3883, ltm4676 > > > > Could we please format this like: > > > > - compatible: should contain one of: > > * "ltc2974" > > * "ltc2977" > > * "ltc2978" > > * "ltc3880" > > * "ltc3883" > > * "ltm4676" > > > > Given the file name, are these all variants of ltc2978? > > > > All the chips supported by the ltc2978 driver. Some are variants > of the ltc2978, some have different functionality. Ok. > > [ should those be "linear,ltc2974" and so on ? ] Good point; yes they should. That will need a vendor-prefixes.txt addition. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html