From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
"atull@opensource.altera.com" <atull@opensource.altera.com>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"delicious.quinoa@gmail.com" <delicious.quinoa@gmail.com>,
"dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>,
"yvanderv@opensource.altera.com" <yvanderv@opensource.altera.com>
Subject: Re: [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation
Date: Sat, 4 Oct 2014 00:13:34 +0100 [thread overview]
Message-ID: <20141003231334.GA4609@sirena.org.uk> (raw)
In-Reply-To: <542EDCDB.6040406@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On Fri, Oct 03, 2014 at 10:28:59AM -0700, Guenter Roeck wrote:
> On 10/03/2014 05:27 AM, Mark Rutland wrote:
> >>+Optional properties:
> >>+ Name of the optional regulator subnode must be "regulators".
> >>+ - #address-cells must be 1.
> >What's the single address cell used for?
> I think this is required by the regulator bindings.
> Other regulators use the same, though they don't typically
> mention it in the properties list but only in the examples.
Nope, nothing to do with regulator that I'm aware of and I've not seen
any examples (but I don't tend to review users too often).
> >Mark, what's the preferred scheme for identifying regulators in a
> >container node?
> >>+ - regulator-name: arbitrary name for regulator
> >Drop the 'aribtarary'. Either this should be the name of the regulator
> >on the board, or it shouldn't be necessary.
> Not sure if it even needs to be documented here. It is already documented
> in Documentation/devicetree/bindings/regulator/regulator.txt.
Document by reference then? It really should be the name of the supply
provided by the regulator, that wording is probably good. Given that
it's a standard regulator property I'd not document it here at all, just
refer to the generic bindings and say any suitable properties there can
be used.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-03 23:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 18:37 [PATCH v5 0/4] This set of patches adds regulator support for pmbus_core.c and ltc2978.c atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-02 18:37 ` [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation atull
[not found] ` <1412275071-6417-2-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-03 12:27 ` Mark Rutland
2014-10-03 13:03 ` Guenter Roeck
[not found] ` <542E9E9B.4090307-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-10-03 13:05 ` Mark Rutland
2014-10-03 15:21 ` Guenter Roeck
2014-10-03 17:28 ` Guenter Roeck
2014-10-03 23:13 ` Mark Brown [this message]
2014-10-03 23:23 ` Guenter Roeck
[not found] ` <542F2FE3.60507-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-10-04 9:53 ` Mark Brown
2014-10-05 0:13 ` Guenter Roeck
2014-10-06 17:28 ` Guenter Roeck
[not found] ` <20141006172845.GA21902-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-10-08 16:12 ` atull
2014-10-08 20:12 ` Guenter Roeck
[not found] ` <20141008201254.GA21065-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-10-08 20:21 ` Mark Brown
[not found] ` <1412275071-6417-1-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-02 18:37 ` [PATCH v5 2/4] pmbus: core: add helpers for byte write and read modify write atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-02 18:37 ` [PATCH v5 3/4] pmbus: add regulator support atull
[not found] ` <1412275071-6417-4-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-03 14:27 ` Mark Brown
[not found] ` <20141003142746.GA24441-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-10-03 15:23 ` Guenter Roeck
2014-10-03 16:42 ` Mark Brown
2014-10-07 14:38 ` atull
2014-10-02 18:37 ` [PATCH v5 4/4] pmbus: ltc2978: " atull
[not found] ` <1412275071-6417-5-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-03 3:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003231334.GA4609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Pawel.Moll@arm.com \
--cc=atull@opensource.altera.com \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jdelvare@suse.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).