From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v5 0/4] Qualcomm SPMI PMIC pin controller drivers
Date: Fri, 3 Oct 2014 16:53:21 -0700 [thread overview]
Message-ID: <20141003235320.GC28481@sonymobile.com> (raw)
In-Reply-To: <1412181058-29179-1-git-send-email-iivanov@mm-sol.com>
On Wed 01 Oct 09:30 PDT 2014, Ivan T. Ivanov wrote:
> Changes since v4:
>
> - Use PMIC name in compatible string.
> - PINCTRL_QCOM_SPMI_PMIC from Kconfig symbol.
> - Remove pmic string from drivers file names.
> - Fixed coding style issues.
> - Use qcom-spmi-gpio and qcom-spmi-mpp from dirver names,
> to be similar to qcom-spmi-iadc, qcom-spmi-vadc and
> qcom-spmi-temp-alarm drivers.
>
> Short description:
>
> Patches adds pin control drivers for Multi-Purpose Pin (MPP) and
> General-purpose pin (GPIO) controllers found in Qualcomm SPMI based
> PMIC chips.
>
> MPP's are enhanced GPIO's with analog circuits, which support
> analog and digital input/output.
>
> v4: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg725568.html
>
> Bjorn Andersson (1):
> pinctrl: Device tree bindings for Qualcomm PMIC GPIO block
>
> Ivan T. Ivanov (3):
> pinctrl: Device tree bindings for Qualcomm PMIC MPP block
> pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver
> pinctrl: Qualcomm SPMI PMIC MPP pin controller driver
>
> .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 215 +++++
> .../devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 162 ++++
> drivers/pinctrl/qcom/Kconfig | 13 +
> drivers/pinctrl/qcom/Makefile | 2 +
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 937 ++++++++++++++++++++
> drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 953 +++++++++++++++++++++
> include/dt-bindings/pinctrl/qcom,pmic-gpio.h | 142 +++
> include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 44 +
> 8 files changed, 2468 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
> create mode 100644 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> create mode 100644 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
> create mode 100644 include/dt-bindings/pinctrl/qcom,pmic-gpio.h
> create mode 100644 include/dt-bindings/pinctrl/qcom,pmic-mpp.h
>
This looks good and I gave it a spin on one of our 8974 devices and verified
that gpio_keys works :)
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Regards,
Bjorn
next prev parent reply other threads:[~2014-10-03 23:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 16:30 [PATCH v5 0/4] Qualcomm SPMI PMIC pin controller drivers Ivan T. Ivanov
[not found] ` <1412181058-29179-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-10-01 16:30 ` [PATCH v5 1/4] pinctrl: Device tree bindings for Qualcomm PMIC GPIO block Ivan T. Ivanov
2014-10-01 16:30 ` [PATCH v5 4/4] pinctrl: Qualcomm SPMI PMIC MPP pin controller driver Ivan T. Ivanov
2014-10-01 16:30 ` [PATCH v5 2/4] pinctrl: Device tree bindings for Qualcomm PMIC MPP block Ivan T. Ivanov
2014-10-01 16:30 ` [PATCH v5 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver Ivan T. Ivanov
2014-10-21 18:15 ` Srinivas Kandagatla
2014-10-22 9:35 ` Ivan T. Ivanov
2014-10-03 23:53 ` Bjorn Andersson [this message]
[not found] ` <20141003235320.GC28481-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-10-07 11:55 ` [PATCH v5 0/4] Qualcomm SPMI PMIC pin controller drivers Ivan T. Ivanov
2014-10-21 10:59 ` Linus Walleij
2014-10-21 11:41 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003235320.GC28481@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).