From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v7 10/11] ARM: at91/dt: add LCD panel description to sama5d3xdm.dtsi Date: Mon, 6 Oct 2014 13:01:16 +0200 Message-ID: <20141006110115.GH25202@ulmo> References: <1412175188-28278-1-git-send-email-boris.brezillon@free-electrons.com> <1412175188-28278-11-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0233613264==" Return-path: In-Reply-To: <1412175188-28278-11-git-send-email-boris.brezillon@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: Mark Rutland , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, Samuel Ortiz , Pawel Moll , Ian Campbell , Lee Jones , Nicolas Ferre , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Alexandre Belloni , Kumar Gala , Jean-Christophe Plagniol-Villard , Andrew Victor , linux-arm-kernel@lists.infradead.org, Mark Yao List-Id: devicetree@vger.kernel.org --===============0233613264== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dx9iWuMxHO1cCoFc" Content-Disposition: inline --Dx9iWuMxHO1cCoFc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 01, 2014 at 04:53:07PM +0200, Boris Brezillon wrote: [...] > diff --git a/arch/arm/boot/dts/sama5d3xdm.dtsi b/arch/arm/boot/dts/sama5d3xdm.dtsi [...] > + bl_reg: backlight_regulator { > + compatible = "regulator-fixed"; > + regulator-name = "backlight-power-supply"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + status = "disabled"; > + }; > + > + panel_reg: panel_regulator { > + compatible = "regulator-fixed"; > + regulator-name = "panel-power-supply"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + status = "disabled"; > + }; > + > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&hlcdc_pwm 0 50000 0>; > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <6>; > + power-supply = <&bl_reg>; > + status = "disabled"; > + }; Why are these all disabled? Patch 11/11 now needs to enable all of them explicitly for each board that uses this display module. > + panel: panel { > + compatible = "foxlink,fl500wvr00-a0t", "simple-panel"; "simple-panel" shouldn't be in this list. There's nothing useful a driver can do by matching on it. > + backlight = <&backlight>; > + power-supply = <&panel_reg>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel_input: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&hlcdc_panel_output>; > + }; > }; There's no support for OF graphs in simple-panel, so this is unused, isn't it? Thierry --Dx9iWuMxHO1cCoFc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUMnZ7AAoJEN0jrNd/PrOh7dQQALTxam4ysRj94M0DSSCpPK8u xAzUFOMBRrJscYVHkyeSUY4RVsvSGnmjR/IY4QcBY1LX2+UnByOWCeMCw2hrhXi9 1OeJMuuGOnubNxN6KOwv1rIZyLeoNZPLuKsUGcL6E/+N4ZYFGuNpklvLdRkCvakn XMR/TV/+8kVw+/s06IqxAZkYsWU0uKo+N+aonOMzRkiGd0+CaBlQAhzeMJqnnUWX eOt+W9Ao3g6zbiYTY8mI4oR/HjFYS9JBH0c9SKMVcXVqysEVjQDFqR+JjAorY6BK r6iTJEf6sNvCFr2QyhRFWCQrtS/RJytkyry5h0+spZw61Q4smzsTIcNl8fP14eo0 6v92i3/oLqwWFa5oFb3JHjGHYcyF4uESZVBcQbn2+M3DipwaoHOdpTK74Xbep/vC Tv+U1f8GOuey0TwZh/BEWcuz3jqR9VzAIDqRdGPK18n3TrdOkFHXb2A2ZHXGwNvC pUOBAZaLcJw2ulbF82KiKBxALED5ozZ6wj63fLLKYDvcb30lSpnSylqIZX4iW9jL qoK8SLiMPvTIx0IVAB/yz4+2/m9byatTqwGjnU1hI5+baxOvQ6/K9gfYYdFV6NYb UQSvcxRWdCsE3xWHlXYWn+CrQNjI2+lvfA+2WsazCvdAbUSlvx0KQyifIdu4YjfT YA8CyY24JMyy2f7R0LXh =7CgZ -----END PGP SIGNATURE----- --Dx9iWuMxHO1cCoFc-- --===============0233613264== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0233613264==--